Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1489293004: win: Fix some warnings reported by /analyze (Closed)

Created:
5 years ago by scottmg
Modified:
5 years ago
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M handler/handler_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M util/win/process_info.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
5 years ago (2015-12-02 21:42:20 UTC) #1
Mark Mentovai
LGTM otherwise https://codereview.chromium.org/1489293004/diff/1/util/win/process_info.cc File util/win/process_info.cc (right): https://codereview.chromium.org/1489293004/diff/1/util/win/process_info.cc#newcode227 util/win/process_info.cc:227: LOG(ERROR) << base::StringPrintf("peb address 0xllx out of ...
5 years ago (2015-12-02 21:46:33 UTC) #2
scottmg
https://codereview.chromium.org/1489293004/diff/1/util/win/process_info.cc File util/win/process_info.cc (right): https://codereview.chromium.org/1489293004/diff/1/util/win/process_info.cc#newcode227 util/win/process_info.cc:227: LOG(ERROR) << base::StringPrintf("peb address 0xllx out of range", On ...
5 years ago (2015-12-02 21:51:57 UTC) #3
scottmg
Committed patchset #2 (id:20001) manually as 894a06070e31e5f8c638af674401d4528d5fdffa (presubmit successful).
5 years ago (2015-12-02 21:52:10 UTC) #5
brucedawson
5 years ago (2015-12-02 23:02:50 UTC) #6
Message was sent while issue was closed.
On 2015/12/02 21:51:57, scottmg wrote:
> https://codereview.chromium.org/1489293004/diff/1/util/win/process_info.cc
> File util/win/process_info.cc (right):
> 
>
https://codereview.chromium.org/1489293004/diff/1/util/win/process_info.cc#ne...
> util/win/process_info.cc:227: LOG(ERROR) << base::StringPrintf("peb address
> 0xllx out of range",
> On 2015/12/02 21:46:33, Mark Mentovai wrote:
> > You lost the %.
> 
> That would have been a poor "improvement"! Thanks.

On the upside, the next /analyze build would have pointed out the problem...

lgtm.

Powered by Google App Engine
This is Rietveld 408576698