Plumb document's strict mixed content checking for RemoteFrames

content/common/frame_messages.h

Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index 72d675141671f3b92c3f4cb8d3a5ed4c11adafbc..3c904d876da3e358a843668fc8615b1e1b82cfc1 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -248,6 +248,10 @@ IPC_STRUCT_BEGIN_WITH_PARENT(FrameHostMsg_DidCommitProvisionalLoad_Params,
 
   // Timestamp at which the UI action that triggered the navigation originated.
   IPC_STRUCT_MEMBER(base::TimeTicks, ui_timestamp)
+
+  // True if the document for the load is enforcing strict mixed content
+  // checking.
+  IPC_STRUCT_MEMBER(bool, should_enforce_strict_mixed_content_checking)
 IPC_STRUCT_END()
 
 IPC_STRUCT_BEGIN(FrameMsg_PostMessage_Params)
@@ -659,6 +663,12 @@ IPC_MESSAGE_ROUTED1(FrameMsg_DidUpdateSandboxFlags, blink::WebSandboxFlags)
 // changed in another process.
 IPC_MESSAGE_ROUTED1(FrameMsg_DidUpdateName, std::string /* name */)
 
+// Update a proxy's replicated enforcement of strict mixed content
+// checking.  Used when the frame's mixed content setting is changed in
+// another process.
+IPC_MESSAGE_ROUTED1(FrameMsg_DidUpdateShouldEnforceStrictMixedContentChecking,

[nasko, 2015/12/17 17:16:33]

nit: I'd drop the "DidUpdateShould" part of the name. We are telling the proxy
to enforce the checks and the boolean clarifies whether it is on or not.

[estark, 2015/12/17 22:19:11]

Done.

+                    bool /* should enforce */)
+
 // Update a proxy's replicated origin.  Used when the frame is navigated to a
 // new origin.
 IPC_MESSAGE_ROUTED1(FrameMsg_DidUpdateOrigin, url::Origin /* origin */)
@@ -816,6 +826,13 @@ IPC_MESSAGE_ROUTED1(FrameHostMsg_UpdateState, content::PageState /* state */)
 // Sent when the frame changes its window.name.
 IPC_MESSAGE_ROUTED1(FrameHostMsg_DidChangeName, std::string /* name */)
 
+// Sent when the frame starts enforcing strict mixed content
+// checking. Sending this information in DidCommitProvisionalLoad isn't
+// sufficient; this message is needed because, for example, a document
+// can dynamically insert a <meta> tag that causes strict mixed content
+// checking to be enforced.
+IPC_MESSAGE_ROUTED0(FrameHostMsg_DidEnforceStrictMixedContentChecking)

[nasko, 2015/12/17 17:16:33]

I find it equally readable, if not more if we drop the "Did", as it is a clear
instruction that checking must be enforced. Here we don't even have an option.

[estark, 2015/12/17 22:19:11]

Done.

+
 // Sent when the renderer changed the progress of a load.
 IPC_MESSAGE_ROUTED1(FrameHostMsg_DidChangeLoadProgress,
                     double /* load_progress */)