content/browser/frame_host/render_frame_host_impl.h - Issue 1489253002: Plumb document's strict mixed content checking for RemoteFrames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1489253002: Plumb document's strict mixed content checking for RemoteFrames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: alexmos test comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index dc05dbf0d204d2f09f3e9593e00535452eceb77c..6f42a24cb57e86822c35dbd061d936a0ab0e8bfb 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -533,6 +533,9 @@ class CONTENT_EXPORT RenderFrameHostImpl

friend class TestRenderViewHost;

FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest, CrashSubframe);

+ FRIEND_TEST_ALL_PREFIXES(

+ RenderFrameHostManagerTestWithSiteIsolation,

+ ProxiesReceiveShouldEnforceStrictMixedContentChecking);

alexmos 2015/12/15 17:49:16 nit: it's probably a bit cleaner to plumb the OnDi

estark 2015/12/15 21:28:49 Done.

// IPC Message handlers.

void OnAddMessageToConsole(int32 level,

@@ -582,6 +585,7 @@ class CONTENT_EXPORT RenderFrameHostImpl

void OnDidAccessInitialDocument();

void OnDidChangeOpener(int32 opener_routing_id);

void OnDidChangeName(const std::string& name);

+ void OnDidEnforceStrictMixedContentChecking();

void OnDidAssignPageId(int32 page_id);

void OnDidChangeSandboxFlags(int32 frame_routing_id,

blink::WebSandboxFlags flags);