Plumb document's strict mixed content checking for RemoteFrames

content/common/frame_messages.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // IPC messages for interacting with frames.
 // Multiply-included message file, hence no include guard.
 
 #include "cc/surfaces/surface_id.h"
 #include "cc/surfaces/surface_sequence.h"
 #include "content/common/content_export.h"
@@ skipping 230 matching lines @@
   // Origin of the frame.  This will be replicated to any associated
   // RenderFrameProxies.
   IPC_STRUCT_MEMBER(url::Origin, origin)
 
   // How navigation metrics starting on UI action for this load should be
   // reported.
   IPC_STRUCT_MEMBER(FrameMsg_UILoadMetricsReportType::Value, report_type)
 
   // Timestamp at which the UI action that triggered the navigation originated.
   IPC_STRUCT_MEMBER(base::TimeTicks, ui_timestamp)
+
+  // True if the document for the load is enforcing strict mixed content
+  // checking.
+  IPC_STRUCT_MEMBER(bool, should_enforce_strict_mixed_content_checking)
 IPC_STRUCT_END()
 
 IPC_STRUCT_BEGIN(FrameMsg_PostMessage_Params)
   // Whether the data format is supplied as serialized script value, or as
   // a simple string. If it is a raw string, must be converted from string to a
   // WebSerializedScriptValue in the renderer process.
   IPC_STRUCT_MEMBER(bool, is_data_raw_string)
 
   // The serialized script value.
   IPC_STRUCT_MEMBER(base::string16, data)
@@ skipping 391 matching lines @@
 // Dispatch a load event in the iframe element containing this frame.
 IPC_MESSAGE_ROUTED0(FrameMsg_DispatchLoad)
 
 // Notifies the frame that its parent has changed the frame's sandbox flags.
 IPC_MESSAGE_ROUTED1(FrameMsg_DidUpdateSandboxFlags, blink::WebSandboxFlags)
 
 // Update a proxy's window.name property.  Used when the frame's name is
 // changed in another process.
 IPC_MESSAGE_ROUTED1(FrameMsg_DidUpdateName, std::string /* name */)
 
+// Update a proxy's replicated enforcement of strict mixed content
+// checking.  Used when the frame's mixed content setting is changed in
+// another process.
+IPC_MESSAGE_ROUTED1(FrameMsg_DidUpdateShouldEnforceStrictMixedContentChecking,

[nasko, 2015/12/17 17:16:33]

nit: I'd drop the "DidUpdateShould" part of the name. We are telling the proxy
to enforce the checks and the boolean clarifies whether it is on or not.

[estark, 2015/12/17 22:19:11]

Done.

+                    bool /* should enforce */)
+
 // Update a proxy's replicated origin.  Used when the frame is navigated to a
 // new origin.
 IPC_MESSAGE_ROUTED1(FrameMsg_DidUpdateOrigin, url::Origin /* origin */)
 
 // Notifies this frame or proxy that it is now focused.  This is used to
 // support cross-process focused frame changes.
 IPC_MESSAGE_ROUTED0(FrameMsg_SetFocusedFrame)
 
 // Send to the RenderFrame to set text tracks state and style settings.
 // Sent for top-level frames.
@@ skipping 137 matching lines @@
 
 // Sent when the renderer is done loading a page.
 IPC_MESSAGE_ROUTED0(FrameHostMsg_DidStopLoading)
 
 // Notifies the browser that this frame has new session history information.
 IPC_MESSAGE_ROUTED1(FrameHostMsg_UpdateState, content::PageState /* state */)
 
 // Sent when the frame changes its window.name.
 IPC_MESSAGE_ROUTED1(FrameHostMsg_DidChangeName, std::string /* name */)
 
+// Sent when the frame starts enforcing strict mixed content
+// checking. Sending this information in DidCommitProvisionalLoad isn't
+// sufficient; this message is needed because, for example, a document
+// can dynamically insert a <meta> tag that causes strict mixed content
+// checking to be enforced.
+IPC_MESSAGE_ROUTED0(FrameHostMsg_DidEnforceStrictMixedContentChecking)

[nasko, 2015/12/17 17:16:33]

I find it equally readable, if not more if we drop the "Did", as it is a clear
instruction that checking must be enforced. Here we don't even have an option.

[estark, 2015/12/17 22:19:11]

Done.

+
 // Sent when the renderer changed the progress of a load.
 IPC_MESSAGE_ROUTED1(FrameHostMsg_DidChangeLoadProgress,
                     double /* load_progress */)
 
 // Requests that the given URL be opened in the specified manner.
 IPC_MESSAGE_ROUTED1(FrameHostMsg_OpenURL, FrameHostMsg_OpenURL_Params)
 
 // Notifies the browser that a frame finished loading.
 IPC_MESSAGE_ROUTED1(FrameHostMsg_DidFinishLoad,
                     GURL /* validated_url */)
@@ skipping 434 matching lines @@
 IPC_MESSAGE_ROUTED1(FrameHostMsg_ShowPopup,
                     FrameHostMsg_ShowPopup_Params)
 IPC_MESSAGE_ROUTED0(FrameHostMsg_HidePopup)
 
 #endif
 
 // Adding a new message? Stick to the sort order above: first platform
 // independent FrameMsg, then ifdefs for platform specific FrameMsg, then
 // platform independent FrameHostMsg, then ifdefs for platform specific
 // FrameHostMsg.