Don't use the Sk4f gradient impl without SIMD

Don't use the Sk4f gradient impl without SIMD

Also remove the SK_SUPPORT_LEGACY_LINEAR_GRADIENT_TABLE guard since it is no
longer used in Chromium.

BUG=chromium:563492
R=reed@google.com,mtklein@google.com
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed: https://skia.googlesource.com/skia/+/c2e0ac4fce5bfe5bac9f2cb1ebd3aea3a8900fb1

[f(malita), 2015-12-03 02:24:15]

Description was changed from

==========
Don't use the Sk4f gradient impl without SIMD

Also remove the SK_SUPPORT_LEGACY_LINEAR_GRADIENT_TABLE since it is no
longer used in Chromium.

BUG=chromium:563492
R=reed@google.com,mtklein@google.com
==========

to

==========
Don't use the Sk4f gradient impl without SIMD

Also remove the SK_SUPPORT_LEGACY_LINEAR_GRADIENT_TABLE since it is no
longer used in Chromium.

BUG=chromium:563492
R=reed@google.com,mtklein@google.com
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[f(malita), 2015-12-03 02:27:18]

Is this a reasonable stop-gap, while waiting for Clank to grow some SIMD?

[f(malita), 2015-12-03 02:27:26]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-03 02:27:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1489233005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1489233005/1

[commit-bot: I haz the power, 2015-12-03 02:39:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 02:39:45]

Dry run: This issue passed the CQ dry run.

[f(malita), 2015-12-03 02:42:02]

Description was changed from

==========
Don't use the Sk4f gradient impl without SIMD

Also remove the SK_SUPPORT_LEGACY_LINEAR_GRADIENT_TABLE since it is no
longer used in Chromium.

BUG=chromium:563492
R=reed@google.com,mtklein@google.com
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Don't use the Sk4f gradient impl without SIMD

Also remove the SK_SUPPORT_LEGACY_LINEAR_GRADIENT_TABLE guard since it is no
longer used in Chromium.

BUG=chromium:563492
R=reed@google.com,mtklein@google.com
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein, 2015-12-03 13:44:21]

lgtm

[reed1, 2015-12-03 14:13:42]

lgtm -- perhaps a more understandable define?

SK_NATIVE_SIMD_COMPILER_SUPPORT?

[mtklein, 2015-12-03 14:14:21]

On 2015/12/03 at 14:13:42, reed wrote:
> lgtm -- perhaps a more understandable define?
> 
> SK_NATIVE_SIMD_COMPILER_SUPPORT?

I was thinking SKNX_IS_FAST.

[f(malita), 2015-12-03 14:16:17]

On 2015/12/03 14:14:21, mtklein wrote:
> On 2015/12/03 at 14:13:42, reed wrote:
> > lgtm -- perhaps a more understandable define?
> > 
> > SK_NATIVE_SIMD_COMPILER_SUPPORT?
> 
> I was thinking SKNX_IS_FAST.

                  ^^ that's exactly what I had in mind initially,
but then decided to complement existing SKNX_NO_SIMD :)

Will update.

[reed1, 2015-12-03 14:19:04]

sg

[mtklein, 2015-12-03 14:23:08]

> but then decided to complement existing SKNX_NO_SIMD :)

Maybe I should update that to
SKNX_PLEASE_NO_SIMD_IM_TRYING_TO_TEST_THE_PORTABLE_FALLBACK_CODE.

[f(malita), 2015-12-03 14:23:35]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2015-12-03 14:23:35]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/1489233005/#ps20001
(title: "SKNX_IS_FAST")

[commit-bot: I haz the power, 2015-12-03 14:23:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1489233005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1489233005/20001

[commit-bot: I haz the power, 2015-12-03 17:15:30]

Description was changed from

==========
Don't use the Sk4f gradient impl without SIMD

Also remove the SK_SUPPORT_LEGACY_LINEAR_GRADIENT_TABLE guard since it is no
longer used in Chromium.

BUG=chromium:563492
R=reed@google.com,mtklein@google.com
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Don't use the Sk4f gradient impl without SIMD

Also remove the SK_SUPPORT_LEGACY_LINEAR_GRADIENT_TABLE guard since it is no
longer used in Chromium.

BUG=chromium:563492
R=reed@google.com,mtklein@google.com
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/c2e0ac4fce5bfe5bac9f2cb1ebd3aea3a8900fb1
==========

[commit-bot: I haz the power, 2015-12-03 17:15:33]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c2e0ac4fce5bfe5bac9f2cb1ebd3aea3a8900fb1