Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 148923003: Add per-file OWNERS for MIPS-specific cctests (Closed)

Created:
6 years, 10 months ago by Jakob Kummerow
Modified:
6 years, 10 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Add per-file OWNERS for MIPS-specific cctests R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
A test/cctest/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
Danno: PTAL. Paul: FYI. I don't see a convenient way to test this change, so ...
6 years, 10 months ago (2014-02-04 08:02:40 UTC) #1
danno
lgtm
6 years, 10 months ago (2014-02-04 09:19:33 UTC) #2
Jakob Kummerow
Committed patchset #1 manually as r19052 (presubmit successful).
6 years, 10 months ago (2014-02-04 09:53:32 UTC) #3
Paul Lind
6 years, 10 months ago (2014-02-10 19:50:53 UTC) #4
Message was sent while issue was closed.
On 2014/02/04 08:02:40, Jakob wrote:
> Paul: FYI. 
> I don't see a convenient way to test this change, so I suggest to test it in
> production :-)

It works, thank-you!

Powered by Google App Engine
This is Rietveld 408576698