Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManagerTest.java

Issue 1489213002: [Contextual Search] Remove layers when no longer needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing broken tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManagerTest.java
index 0a7d394acbc79450c49b55233ef798b29b3a6631..6d590bd8a1a3a1c8134b9db9bc41b80369ba23cf 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManagerTest.java
@@ -55,13 +55,15 @@ public class ReaderModeManagerTest extends InstrumentationTestCase {
private int mPanelHideCount;
@Override
- public void requestPanelShow(OverlayPanel p, StateChangeReason r) {
+ public void requestPanelShow(OverlayPanel panel, StateChangeReason reason) {
mRequestPanelShowCount++;
+ super.requestPanelShow(panel, reason);
}
@Override
- public void notifyPanelClosed(OverlayPanel p, StateChangeReason r) {
+ public void notifyPanelClosed(OverlayPanel panel, StateChangeReason reason) {
mPanelHideCount++;
+ super.notifyPanelClosed(panel, reason);
}
public int getRequestPanelShowCount() {
@@ -162,12 +164,14 @@ public class ReaderModeManagerTest extends InstrumentationTestCase {
@SmallTest
@Feature({"ReaderModeManager"})
public void testInfoBarEvents() {
+ mPanel.requestPanelShow(StateChangeReason.UNKNOWN);
+
mReaderManager.onAddInfoBar(null, null, true);
- assertEquals(0, mPanelManager.getRequestPanelShowCount());
+ assertEquals(1, mPanelManager.getRequestPanelShowCount());
assertEquals(1, mPanelManager.getPanelHideCount());
mReaderManager.onRemoveInfoBar(null, null, true);
- assertEquals(1, mPanelManager.getRequestPanelShowCount());
+ assertEquals(2, mPanelManager.getRequestPanelShowCount());
assertEquals(1, mPanelManager.getPanelHideCount());
}
@@ -177,12 +181,14 @@ public class ReaderModeManagerTest extends InstrumentationTestCase {
@SmallTest
@Feature({"ReaderModeManager"})
public void testFullscreenEvents() {
+ mPanel.requestPanelShow(StateChangeReason.UNKNOWN);
+
mReaderManager.onToggleFullscreenMode(null, true);
- assertEquals(0, mPanelManager.getRequestPanelShowCount());
+ assertEquals(1, mPanelManager.getRequestPanelShowCount());
assertEquals(1, mPanelManager.getPanelHideCount());
mReaderManager.onToggleFullscreenMode(null, false);
- assertEquals(1, mPanelManager.getRequestPanelShowCount());
+ assertEquals(2, mPanelManager.getRequestPanelShowCount());
assertEquals(1, mPanelManager.getPanelHideCount());
}

Powered by Google App Engine
This is Rietveld 408576698