chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java - Issue 1489213002: [Contextual Search] Remove layers when no longer needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

Issue 1489213002: [Contextual Search] Remove layers when no longer needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/StaticLayout.java » ('j') | chrome/browser/android/compositor/scene_layer/static_tab_scene_layer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

index ae8da8ee55df44662091e9d33015c7c5daaf50a2..aaca4012fc12705fd68d348e64c45de49a55a590 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

@@ -78,9 +78,10 @@ public class LayoutManagerDocument extends LayoutManager

private final SparseArray<LayoutTab> mTabCache = new SparseArray<LayoutTab>();

private final ContextualSearchPanel mContextualSearchPanel;

private final ReaderModePanel mReaderModePanel;

- private final OverlayPanelManager mOverlayPanelManager;

+ /** A delegate for interacting with the OverlayPanel manager. */

+ protected final OverlayPanelManager mOverlayPanelManager;

/** A delegate for interacting with the Contextual Search manager. */

- protected ContextualSearchManagementDelegate mContextualSearchDelegate;

+ private ContextualSearchManagementDelegate mContextualSearchDelegate;

@SuppressWarnings("unused") private TabModelSelectorTabObserver mTabModelSelectorTabObserver;