Precompilation: Don't drop an uncompiled function if it has a compiled implicit closure function.

Precompilation: Don't drop an uncompiled function if it has a compiled implicit closure function.

This ensures the implicit closure function is enumerated in later steps. Fixes crash in co19 test reducible as

import 'dart:math';
main() {
  print(const [1, 2.0, "3"].fold(0, max));
}

Also enumerate invocation dispatchers to avoid a similar situation there, though I cannot find a crashing example involving them.

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/d94b68cb41d5b6cb9a4c536c19911bac4f1f5b9a

[rmacnak, 2015-12-03 01:53:22]

rmacnak@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2015-12-03 11:52:23]

lgtm

[rmacnak, 2015-12-03 19:03:26]

Description was changed from

==========
Precompilation: Don't drop an uncompiled function if it has a compiled implicit
closure function.

This ensures the implicit closure function is enumerated in later steps. Fixes
crash in co19 test reducible as

import 'dart:math';
main() {
  print(const [1, 2.0, "3"].fold(0, max));
}

Also enumerate invocation dispatchers to avoid a similar situation there, though
I cannot find a crashing example involving them.
==========

to

==========
Precompilation: Don't drop an uncompiled function if it has a compiled implicit
closure function.

This ensures the implicit closure function is enumerated in later steps. Fixes
crash in co19 test reducible as

import 'dart:math';
main() {
  print(const [1, 2.0, "3"].fold(0, max));
}

Also enumerate invocation dispatchers to avoid a similar situation there, though
I cannot find a crashing example involving them.

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d94b68cb41d5b6cb9a4c536c19911bac4f1f5b9a
==========

[rmacnak, 2015-12-03 19:03:27]

Committed patchset #1 (id:1) manually as
d94b68cb41d5b6cb9a4c536c19911bac4f1f5b9a (presubmit successful).