Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 148913008: A64: Fix some compile errors when building for Android. (Closed)

Created:
6 years, 10 months ago by rmcilroy
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Fix some compile errors when building for Android. - replace __arm__ define checks with __aarch64__ - add 64 bit ucontext_t struct definition - fix V8_HOST_ARCH_A64 compile errors in sampler.cc - add aarch64 brk assembly instruction for debug break R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18961

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -22 lines) Patch
M src/a64/cpu-a64.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/isolate.h View 1 6 chunks +7 lines, -7 lines 0 comments Download
M src/isolate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/platform-freebsd.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/platform-linux.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M src/sampler.cc View 4 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmcilroy
PTAL. I've not tried running it yet, but this gets us most of the way ...
6 years, 10 months ago (2014-01-30 03:53:08 UTC) #1
ulan
[+Rodolph fyi] LGTM
6 years, 10 months ago (2014-01-30 08:46:33 UTC) #2
Rodolph Perfetta (ARM)
https://codereview.chromium.org/148913008/diff/1/src/a64/cpu-a64.cc File src/a64/cpu-a64.cc (right): https://codereview.chromium.org/148913008/diff/1/src/a64/cpu-a64.cc#newcode29 src/a64/cpu-a64.cc:29: #ifdef __aarch64__ The current port does not use syscall ...
6 years, 10 months ago (2014-01-30 11:17:15 UTC) #3
rmcilroy
Thanks! https://codereview.chromium.org/148913008/diff/1/src/a64/cpu-a64.cc File src/a64/cpu-a64.cc (right): https://codereview.chromium.org/148913008/diff/1/src/a64/cpu-a64.cc#newcode29 src/a64/cpu-a64.cc:29: #ifdef __aarch64__ On 2014/01/30 11:17:15, Rodolph Perfetta (ARM) ...
6 years, 10 months ago (2014-01-30 18:16:42 UTC) #4
rmcilroy
6 years, 10 months ago (2014-01-30 18:17:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r18961 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698