Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 148913006: Skip Mozilla tests with timeouts. (Closed)

Created:
6 years, 10 months ago by Michael Achenbach
Modified:
6 years, 10 months ago
Reviewers:
Yang, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Skip Mozilla tests with timeouts. - Let Mozilla tests with timeouts always run in no-variants mode. Otherwise the stress-run causes a 16 minutes timeout in debug mode and 32 minutes on arm debug. - Four test cases with exponentially long running regular expressions are skipped entirely. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M test/mozilla/mozilla.status View 10 chunks +24 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL [+Yang for the TODOs]
6 years, 10 months ago (2014-01-29 14:11:11 UTC) #1
Jakob Kummerow
LGTM. To record our offline conversation: We could put the "TIMEOUT implies NOVARIANTS" logic into ...
6 years, 10 months ago (2014-01-29 15:12:36 UTC) #2
Michael Achenbach
6 years, 10 months ago (2014-01-29 15:13:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18916 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698