Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148913005: Create fileapi/ subdirectory under c/b/cros/drive. (Closed)

Created:
6 years, 10 months ago by kinaba
Modified:
6 years, 10 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, tfarina, nhiroki, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Create fileapi/ subdirectory under c/b/cros/drive. We have quite a few number (12) of files for providing interfaces to FileSystem API. They can be clearly separated from other files under drive/. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2259 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/drive/async_file_util.h View 1 chunk +0 lines, -109 lines 0 comments Download
D chrome/browser/chromeos/drive/async_file_util.cc View 1 chunk +0 lines, -437 lines 0 comments Download
D chrome/browser/chromeos/drive/file_system_backend_delegate.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/chromeos/drive/file_system_backend_delegate.cc View 1 chunk +0 lines, -83 lines 0 comments Download
A + chrome/browser/chromeos/drive/fileapi/async_file_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/drive/fileapi/async_file_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/drive/fileapi/fileapi_worker.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/drive/fileapi/fileapi_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/drive/fileapi/fileapi_worker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/drive/fileapi/webkit_file_stream_writer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/drive/fileapi/webkit_file_stream_writer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/drive/fileapi_worker.h View 1 chunk +0 lines, -179 lines 0 comments Download
D chrome/browser/chromeos/drive/fileapi_worker.cc View 1 chunk +0 lines, -366 lines 0 comments Download
D chrome/browser/chromeos/drive/fileapi_worker_unittest.cc View 1 chunk +0 lines, -273 lines 0 comments Download
D chrome/browser/chromeos/drive/webkit_file_stream_reader_impl.h View 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/browser/chromeos/drive/webkit_file_stream_reader_impl.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D chrome/browser/chromeos/drive/webkit_file_stream_reader_impl_unittest.cc View 1 chunk +0 lines, -208 lines 0 comments Download
D chrome/browser/chromeos/drive/webkit_file_stream_writer_impl.h View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/chromeos/drive/webkit_file_stream_writer_impl.cc View 1 chunk +0 lines, -179 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinaba
hashimoto: what do you think?
6 years, 10 months ago (2014-01-29 07:14:07 UTC) #1
hashimoto
lgtm
6 years, 10 months ago (2014-01-29 07:18:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/148913005/1
6 years, 10 months ago (2014-01-29 07:21:09 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=217820
6 years, 10 months ago (2014-01-29 08:29:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/148913005/1
6 years, 10 months ago (2014-01-29 08:35:52 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 11:22:00 UTC) #6
Message was sent while issue was closed. 
Change committed as 247674

Powered by Google App Engine
This is Rietveld 408576698