pkg/polymer/lib/src/build/import_inliner.dart - Issue 148913003: Improve how we handle packages/ HTML imports. This resolves better any valid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/polymer/lib/src/build/import_inliner.dart

Issue 148913003: Improve how we handle packages/ HTML imports. This resolves better any valid (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/polymer/example/canonicalization3/pubspec.yaml ('K') | « pkg/polymer/lib/src/build/common.dart ('k') | pkg/polymer/lib/src/loader.dart » ('j') | tools/testing/dart/test_controller.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/polymer/lib/src/build/import_inliner.dart

diff --git a/pkg/polymer/lib/src/build/import_inliner.dart b/pkg/polymer/lib/src/build/import_inliner.dart

index 79298c16bc0c6f4d98229ffaf9eb96dbf169027b..a66d1bbc84176faefcc440d0c9f6772617128ed3 100644

--- a/pkg/polymer/lib/src/build/import_inliner.dart

+++ b/pkg/polymer/lib/src/build/import_inliner.dart

@@ -182,6 +182,7 @@ class _UrlNormalizer extends TreeVisitor {

if (path.isAbsolute(href)) return href;

var id = resolve(sourceId, href, transform.logger, span);

+ if (id == null) return href;

var primaryId = transform.primaryInput.id;

if (id.path.startsWith('lib/')) {