Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1489103002: [NaCl SDK] Remove support for bionic toolchain (Closed)

Created:
5 years ago by Sam Clegg
Modified:
5 years ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Elliot Glaysher
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Remove support for bionic toolchain Second attempt at landing. First attempt was reverted: https://codereview.chromium.org/1269623004 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk;tryserver.chromium.linux:linux_chromium_rel_ng Committed: https://crrev.com/ceda85ca05919c079157638b3f0fa7fa8ee7e9b1 Cr-Commit-Position: refs/heads/master@{#362611}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -848 lines) Patch
M native_client_sdk/src/BUILDING.rst View 1 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/build_projects.py View 1 4 chunks +0 lines, -9 lines 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 1 13 chunks +6 lines, -69 lines 0 comments Download
M native_client_sdk/src/build_tools/buildbot_common.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/buildbot_run.py View 1 2 chunks +0 lines, -7 lines 0 comments Download
M native_client_sdk/src/build_tools/json/naclsdk_manifest2.json View 1 1 chunk +0 lines, -10 lines 0 comments Download
M native_client_sdk/src/build_tools/parse_dsc.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/tests/update_nacl_manifest_test.py View 1 5 chunks +1 line, -25 lines 0 comments Download
M native_client_sdk/src/build_tools/update_nacl_manifest.py View 1 6 chunks +4 lines, -22 lines 0 comments Download
M native_client_sdk/src/doc/sdk/download.rst View 1 2 chunks +0 lines, -2 lines 0 comments Download
M native_client_sdk/src/examples/demo/nacl_io_demo/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/jsfs/js_fs_node.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/kernel_wrap_bionic.cc View 1 1 chunk +0 lines, -502 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/library.dsc View 1 2 chunks +1 line, -2 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_simple/library.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_simple_cpp/library.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
D native_client_sdk/src/libraries/ppapi_stub/library.dsc View 1 1 chunk +0 lines, -19 lines 0 comments Download
D native_client_sdk/src/libraries/ppapi_stub/main.c View 1 1 chunk +0 lines, -17 lines 0 comments Download
D native_client_sdk/src/libraries/ppapi_stub/ppapi_main.c View 1 1 chunk +0 lines, -110 lines 0 comments Download
M native_client_sdk/src/resources/Makefile.library.template View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tools/common.mk View 1 2 chunks +1 line, -5 lines 0 comments Download
M native_client_sdk/src/tools/create_nmf.py View 1 1 chunk +0 lines, -7 lines 0 comments Download
M native_client_sdk/src/tools/lib/get_shared_deps.py View 1 1 chunk +3 lines, -10 lines 0 comments Download
M native_client_sdk/src/tools/nacl_gcc.mk View 1 5 chunks +2 lines, -19 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
Sam Clegg
5 years ago (2015-12-01 19:09:58 UTC) #2
binji
lgtm
5 years ago (2015-12-01 19:23:06 UTC) #3
gab
On 2015/12/01 19:23:06, binji wrote: > lgtm Land with NOTREECHECKS=true NOTRY=true just like we would ...
5 years ago (2015-12-01 20:05:56 UTC) #8
Sam Clegg
On 2015/12/01 20:05:56, gab wrote: > On 2015/12/01 19:23:06, binji wrote: > > lgtm > ...
5 years ago (2015-12-01 20:08:42 UTC) #9
gab
On 2015/12/01 20:08:42, Sam Clegg wrote: > On 2015/12/01 20:05:56, gab wrote: > > On ...
5 years ago (2015-12-01 20:09:51 UTC) #10
Sam Clegg
Including the re-land of the bionic change. PTAL.
5 years ago (2015-12-01 20:29:21 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489103002/20001
5 years ago (2015-12-01 20:52:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489103002/20001
5 years ago (2015-12-02 00:53:07 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-02 03:07:56 UTC) #23
commit-bot: I haz the power
5 years ago (2015-12-02 03:08:37 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ceda85ca05919c079157638b3f0fa7fa8ee7e9b1
Cr-Commit-Position: refs/heads/master@{#362611}

Powered by Google App Engine
This is Rietveld 408576698