Remove function level static initializers media library initialization.

media/base/media_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/media.h"
 
 #include <cpu-features.h>
 
 #include "base/android/jni_android.h"
-#include "base/logging.h"
+#include "base/files/file_path.h"
 #include "media/base/android/media_jni_registrar.h"
 
 namespace media {
+namespace internal {
 
-// Caches the result of the check for NEON support.
-static bool g_media_library_is_initialized = false;
+bool InitializeMediaLibraryInternal(const base::FilePath& module_dir,
+                                    bool for_testing) {

[scherkus (not reviewing), 2013/05/03 17:44:43]

this is the only place where |for_testing| is used, which makes me wonder about
whether the RegisterJni() code should really be here or whether it was placed
here out of convenience


if we need to call this once for running unit tests then a better place would be
inside media/base/run_all_unittests.cc

+  if (for_testing) {
+    // Register JNI bindings for android.
+    JNIEnv* env = base::android::AttachCurrentThread();
+    RegisterJni(env);
+  }
 
-bool InitializeMediaLibrary(const base::FilePath& module_dir) {
   // No real initialization is necessary but we do need to check if
   // Neon is supported because the FFT library requires Neon.
-  g_media_library_is_initialized = (android_getCpuFeatures() &
-                                    ANDROID_CPU_ARM_FEATURE_NEON) != 0;
-  return g_media_library_is_initialized;
+  return (android_getCpuFeatures() & ANDROID_CPU_ARM_FEATURE_NEON) != 0;
 }
 
-void InitializeMediaLibraryForTesting() {
-  // Register JNI bindings for android.
-  JNIEnv* env = base::android::AttachCurrentThread();
-  RegisterJni(env);
-}
-
-bool IsMediaLibraryInitialized() {
-  return g_media_library_is_initialized;
-}
-
+}  // namespace internal
 }  // namespace media