Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: tool/sdk_expected_errors.txt

Issue 1489043002: More mirrors (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tool/sdk_expected_errors.txt
diff --git a/tool/sdk_expected_errors.txt b/tool/sdk_expected_errors.txt
index a6c50f7855c3b02f22dea9a557b653b62eb78dd4..4dd486907ab9b7fcbfe7c890452673f28a288690 100644
--- a/tool/sdk_expected_errors.txt
+++ b/tool/sdk_expected_errors.txt
@@ -274,3 +274,4 @@ warning: [DownCastComposite] min(a.y, b.y) (num) will need runtime check to cast
warning: [DownCastComposite] max(a.y, b.y) - top (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 231, col 16)
warning: [DownCastComposite] _clampToZero(width) (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 247, col 28)
warning: [DownCastComposite] _clampToZero(height) (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 263, col 30)
+warning: [DownCastComposite] interfaces().map((t) => new JsClassMirror._(t)) (dynamic) will need runtime check to cast to type List<ClassMirror> (dart:_js_mirrors, line 127, col 14)
Jennifer Messerly 2015/12/01 16:41:39 this should go away after suggested fix :)
vsm 2015/12/01 17:00:01 Still have the JS one. Is there a way to tell it
Jennifer Messerly 2015/12/01 17:13:49 No. But we should have it always trust JS builtin
« tool/input_sdk/private/js_mirrors.dart ('K') | « tool/input_sdk/private/js_mirrors.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698