Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3902)

Unified Diff: bench/ResultsWriter.h

Issue 1489033004: Began logging more gpu stats from nanobench (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: no gpu support Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « bench/Benchmark.h ('k') | bench/SKPBench.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/ResultsWriter.h
diff --git a/bench/ResultsWriter.h b/bench/ResultsWriter.h
index 2906429bf0acc6fb74ab25152476a111343d32f7..bf74d47826cca1243b8eb5eb01df361781f2674f 100644
--- a/bench/ResultsWriter.h
+++ b/bench/ResultsWriter.h
@@ -87,26 +87,26 @@ public:
}
// Added under "key".
- virtual void key(const char name[], const char value[]) {
+ void key(const char name[], const char value[]) override {
fRoot["key"][name] = value;
}
// Inserted directly into the root.
- virtual void property(const char name[], const char value[]) {
+ void property(const char name[], const char value[]) override {
fRoot[name] = value;
}
- virtual void bench(const char name[], int32_t x, int32_t y) {
+ void bench(const char name[], int32_t x, int32_t y) override {
SkString id = SkStringPrintf( "%s_%d_%d", name, x, y);
fResults[id.c_str()] = Json::Value(Json::objectValue);
fBench = &fResults[id.c_str()];
}
- virtual void config(const char name[]) {
+ void config(const char name[]) override {
SkASSERT(fBench);
fConfig = &(*fBench)[name];
}
- virtual void configOption(const char name[], const char* value) {
+ void configOption(const char name[], const char* value) override {
(*fConfig)["options"][name] = value;
}
- virtual void metric(const char name[], double ms) {
+ void metric(const char name[], double ms) override {
// Don't record if nan, or -nan.
if (sk_double_isnan(ms)) {
return;
@@ -116,7 +116,7 @@ public:
}
// Flush to storage now please.
- virtual void flush() {
+ void flush() override {
SkString dirname = SkOSPath::Dirname(fFilename.c_str());
if (!sk_exists(dirname.c_str(), kWrite_SkFILE_Flag)) {
if (!sk_mkdir(dirname.c_str())) {
« no previous file with comments | « bench/Benchmark.h ('k') | bench/SKPBench.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698