Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148903003: Roll DEPS for tools/gyp from 1846 to 1852 (Closed)

Created:
6 years, 10 months ago by sdefresne
Modified:
6 years, 10 months ago
Reviewers:
blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Roll DEPS for tools/gyp to 1852 r1852: (sdefresne) Fix generation for ninja of multiarch executable targets r1851: (sdefresne) Use "formats" parameter to TestGyp to filter the format r1850: (sdefresne) Improve ninja's Xcode emulation r1849: (sdefresne) Extract XcodeVersion to be a standalone module function r1848: (sdefresne) Fix comparison of Xcode version r1847: (scottmg) Ninja generator: check if meminfo exists before reading it. BUG=314720 R=blundell Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250989

Patch Set 1 #

Patch Set 2 : Update roll to r1852 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
sdefresne
PTAL
6 years, 10 months ago (2014-02-12 08:49:13 UTC) #1
blundell
lgtm
6 years, 10 months ago (2014-02-12 09:38:51 UTC) #2
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 10 months ago (2014-02-12 09:38:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/148903003/1
6 years, 10 months ago (2014-02-12 09:39:07 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 10:14:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_rel_device_ninja for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device_ninja&number=1666
6 years, 10 months ago (2014-02-12 10:14:11 UTC) #6
sdefresne
FYI: Fixed the bug in gyp, and updated the code to get it. Started another ...
6 years, 10 months ago (2014-02-12 16:21:06 UTC) #7
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 10 months ago (2014-02-12 16:24:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/148903003/300001
6 years, 10 months ago (2014-02-12 16:24:54 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 21:58:30 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=262710
6 years, 10 months ago (2014-02-12 21:58:30 UTC) #11
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 10 months ago (2014-02-13 10:22:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/148903003/300001
6 years, 10 months ago (2014-02-13 10:22:56 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 14:35:03 UTC) #14
Message was sent while issue was closed. 
Change committed as 250989

Powered by Google App Engine
This is Rietveld 408576698