Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1489013002: Disable blink_perf.bindings benchmark on Android Svelte (Closed)

Created:
5 years ago by petrcermak
Modified:
5 years ago
Reviewers:
haraken, bashi, Sami, Yuki
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable blink_perf.bindings benchmark on Android Svelte The benchmark is failing on downstream Android Svelte bots. NOTRY=true TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org BUG=563979 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/27963a3f1cb0adb9948adf48bf9231ad334b5575 Cr-Commit-Position: refs/heads/master@{#362404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/perf/benchmarks/blink_perf.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
petrcermak
Hi, Please review this tiny patch. Thanks, Petr
5 years ago (2015-12-01 13:01:08 UTC) #3
Sami
lgtm.
5 years ago (2015-12-01 13:19:43 UTC) #4
haraken
LGTM as a short-term fix, but this needs to be fixed. blink_perf.bindings contains a bunch ...
5 years ago (2015-12-01 13:20:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489013002/1
5 years ago (2015-12-01 13:34:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 13:38:55 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/27963a3f1cb0adb9948adf48bf9231ad334b5575 Cr-Commit-Position: refs/heads/master@{#362404}
5 years ago (2015-12-01 13:39:58 UTC) #10
Yuki
lgtm
5 years ago (2015-12-02 07:45:51 UTC) #11
jbroman
3 years, 7 months ago (2017-05-16 20:30:44 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2890623002/ by jbroman@chromium.org.

The reason for reverting is: Hoping that this is no longer broken; most of the
data that would be helpful in debugging is gone to the sands of time (see bug).

Perf sheriffs: if blink_perf.bindings starts failing on Svelte, this CL is the
culprit and you should revert it..

Powered by Google App Engine
This is Rietveld 408576698