Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: third_party/WebKit/Source/core/html/HTMLImageElement.cpp

Issue 1489003002: Drop Image::setContainerSize() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Back to ps#1 way, with fixed is_expensive test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLImageElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLImageElement.cpp b/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
index 6c492e273da854fdbb0747be8ecc5d36c61fde20..858b47ac3fcf904668c8797fc5d24b541e5e6fc5 100644
--- a/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
@@ -48,6 +48,7 @@
#include "core/layout/LayoutImage.h"
#include "core/page/Page.h"
#include "core/style/ContentData.h"
+#include "core/svg/graphics/SVGImageForContainer.h"
#include "platform/ContentType.h"
#include "platform/EventDispatchForbiddenScope.h"
#include "platform/MIMETypeRegistry.h"
@@ -604,16 +605,23 @@ PassRefPtr<Image> HTMLImageElement::getSourceImageForCanvas(SourceImageStatus* s
return nullptr;
}
- RefPtr<Image> sourceImage = cachedImage()->image();
-
- // We need to synthesize a container size if a layoutObject is not available to provide one.
- if (!layoutObject() && sourceImage->usesContainerSize())
- sourceImage->setContainerSize(sourceImage->size());
+ RefPtr<Image> sourceImage;
+ if (cachedImage()->image()->isSVGImage()) {
+ sourceImage = SVGImageForContainer::create(toSVGImage(cachedImage()->image()),
+ cachedImage()->image()->size(), 1, document().completeURL(imageSourceURL()));
+ } else {
+ sourceImage = cachedImage()->image();
+ }
*status = NormalSourceImageStatus;
return sourceImage->imageForDefaultFrame();
}
+bool HTMLImageElement::isSVGSource() const
+{
+ return cachedImage() && cachedImage()->image()->isSVGImage();
+}
+
bool HTMLImageElement::wouldTaintOrigin(SecurityOrigin* destinationSecurityOrigin) const
{
ImageResource* image = cachedImage();
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLImageElement.h ('k') | third_party/WebKit/Source/core/html/canvas/CanvasImageSource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698