third_party/WebKit/LayoutTests/svg/canvas/canvas-draw-svg-fragments.html - Issue 1489003002: Drop Image::setContainerSize()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/canvas/canvas-draw-svg-fragments.html

Issue 1489003002: Drop Image::setContainerSize() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>drawImage() with SVG fragments</title>

	3 <script>

	4 onload = function() {

	5 var context = document.getElementsByTagName('canvas')[0].getContext('2d' );

	6 var images = document.getElementsByTagName('img');

	7 for (var i = 0; i < images.length; i++) {

	8 var domImage = images.item(i);
	fs 2015/12/01 14:23:21 Nit: images[i]? (any particular reason to use item Nit: images[i]? (any particular reason to use item(...)?)
	9 var newImage = new Image();

	10 newImage.src = domImage.src;

	11 context.drawImage(newImage, i60, i60, 120, 120);

	12 }

	13 while (images.length)

	14 document.body.removeChild(images.item(0));

	15 }

	16 </script>

	17 <canvas width="240px" height="240px"></canvas>
	fs 2015/12/01 14:23:21 Nit: 'px' will be "trailing garbage" in this conte Nit: 'px' will be "trailing garbage" in this context.
	18 <img src="../css/resources/fragment-identifiers.svg#green">

	19 <img src="../css/resources/fragment-identifiers.svg#red">

	20 <img src="../css/resources/fragment-identifiers.svg#blue">

OLD	NEW