Add split-dll build to main waterfall

masters/master.chromium/master_full_cfg.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from master import master_config
 from master.factory import chromium_factory
 
 import master_site_config
 
 ActiveMaster = master_site_config.Chromium
 
 defaults = {}
 
 helper = master_config.Helper(defaults)
 B = helper.Builder
 D = helper.Dependent
 F = helper.Factory
 S = helper.Scheduler
 T = helper.Triggerable
 
 def win(): return chromium_factory.ChromiumFactory('src/build', 'win32')

[iannucci1, 2013/05/22 22:39:47]

add a win_out() which has build_dir set to 'src/out'

[scottmg, 2013/05/22 22:48:27]

Done.

 def linux(): return chromium_factory.ChromiumFactory('src/out', 'linux2')
 def mac(): return chromium_factory.ChromiumFactory('src/xcodebuild', 'darwin')
 def linux_android(): return chromium_factory.ChromiumFactory(
     'src/out', 'linux2', nohooks_on_update=True, target_os='android')
 
 defaults['category'] = '1clobber'
 
 # Global scheduler
 S('chromium', branch='src', treeStableTimer=60)
 
@@ skipping 19 matching lines @@
       'perf_id': 'chromium-rel-xp',
       'expectations': True,
       'process_dumps': True,
       'start_crash_handler': True,
       'generate_gtest_json': ActiveMaster.is_production_host,
       'gclient_env': {
         'GYP_DEFINES': 'test_isolation_mode=noop',
       },
     }))
 
+B('Win Split', 'win_split', 'compile|windows', 'chromium')
+F('win_split', win().ChromiumFactory(

[iannucci1, 2013/05/22 22:39:47]

use it here

[scottmg, 2013/05/22 22:48:27]

Done.

+    target='Release',
+    options=['--build-tool=ninja']

[iannucci1, 2013/05/22 22:39:47]

Do you want to specify the targets to build a la the linux_clobber builder
below?

[scottmg, 2013/05/22 22:48:27]

Sorry, not sure what you mean here. Adding a 'tests' block? I wanted to just get
the building up first, but maybe what I could do is also add the script, but
make it always pass for now so that we don't need another restart later. Did
that.

[iannucci, 2013/05/22 23:04:08]

Meaning, do you want to compile something specific as opposed to the default
build set (maybe All or chromium_builder_tests?)

+    factory_properties={
+      'expectations': True,
+      'process_dumps': True,
+      'start_crash_handler': True,
+      'gclient_env': {
+        'GYP_DEFINES': 'fastbuild=1 chrome_split_dll=1',

[iannucci1, 2013/05/22 22:39:47]

I think you need GYP_GENERATORS=ninja here

[scottmg, 2013/05/22 22:48:27]

Done.

+      },
+    }))
+
+
 ################################################################################
 ## Mac
 ################################################################################
 
 B('Mac', 'mac_clobber', 'compile|testers', 'chromium',
   notify_on_missing=True)
 F('mac_clobber', mac().ChromiumFactory(
     clobber=True,
     tests=[
       'check_deps2git',
@@ skipping 84 matching lines @@
       'gs_bucket': 'gs://chromium-browser-snapshots',
       'perf_id': 'android-release',
       'show_perf_results': True,
     },
     annotation_script='src/build/android/buildbot/bb_run_bot.py',
     ))
 
 
 def Update(_config, active_master, c):
   return helper.Update(c)