Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 14890017: GM: include filename extension (.png) of each output file in JSON summary (Closed)

Created:
7 years, 7 months ago by epoger
Modified:
7 years, 7 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

GM: include filename extension (.png) of each output file in JSON summary Doing this so that, once we *do* start writing PDF checksums into the JSON summary, we'll be able to distinguish those from the PNG checksums. Otherwise, we could have naming collisions. R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=9119

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove_all_png_extensions_from_gm_expectations.cpp #

Total comments: 1

Patch Set 3 : sync_to_r9081_so_trybots_are_happy #

Patch Set 4 : use_appendUnichar_instead_of_append #

Total comments: 1

Patch Set 5 : sync_to_r9118 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -64 lines) Patch
M gm/gm_expectations.h View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M gm/gm_expectations.cpp View 1 2 3 4 2 chunks +15 lines, -9 lines 0 comments Download
M gm/gmmain.cpp View 1 2 3 4 6 chunks +17 lines, -4 lines 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-images/output-expected/json-summary.txt View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-images/output-expected/stderr View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-json/output-expected/json-summary.txt View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-images/output-expected/json-summary.txt View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-json/output-expected/json-summary.txt View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-images/output-expected/json-summary.txt View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-json/output-expected/json-summary.txt View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/ignore-expectations-mismatch/output-expected/json-summary.txt View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/intentionally-skipped-tests/output-expected/json-summary.txt View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/no-readpath/output-expected/json-summary.txt View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M gm/tests/outputs/nonverbose/output-expected/json-summary.txt View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/pipe-playback-failure/output-expected/json-summary.txt View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download
M gm/tests/outputs/pipe-playback-failure/output-expected/stderr View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
https://codereview.chromium.org/14890017/diff/1/gm/gm.h File gm/gm.h (right): https://codereview.chromium.org/14890017/diff/1/gm/gm.h#newcode1 gm/gm.h:1: Patchset 1 just applies the diffs from https://codereview.chromium.org/15014011/#ps10006 . ...
7 years, 7 months ago (2013-05-09 18:26:01 UTC) #1
epoger
Ready for review at patchset 2, which moves *all* of the file-extension adding into gmmain.cpp. ...
7 years, 7 months ago (2013-05-09 19:45:43 UTC) #2
epoger
Ready for review at patchset 4, I promise this time. https://codereview.chromium.org/14890017/diff/14001/gm/gm_expectations.cpp File gm/gm_expectations.cpp (right): https://codereview.chromium.org/14890017/diff/14001/gm/gm_expectations.cpp#newcode38 ...
7 years, 7 months ago (2013-05-09 20:06:57 UTC) #3
scroggo
lgtm
7 years, 7 months ago (2013-05-13 15:05:43 UTC) #4
epoger
7 years, 7 months ago (2013-05-14 15:17:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r9119 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698