Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 1488953003: [turbofan] Print API for Node. (Closed)

Created:
5 years ago by Mircea Trofin
Modified:
5 years ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Print API for Node. Node has an operator<<, however, constructing an ostream in a debugger session is non-trivial, hence this method. BUG= Committed: https://crrev.com/7a52e179dcba39c26ab3db1fef6c0f7f9c673b11 Cr-Commit-Position: refs/heads/master@{#32439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/compiler/node.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/node.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Mircea Trofin
5 years ago (2015-12-01 05:42:19 UTC) #3
Benedikt Meurer
lgtm
5 years ago (2015-12-01 05:42:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488953003/1
5 years ago (2015-12-01 05:46:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 06:27:15 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-01 06:28:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a52e179dcba39c26ab3db1fef6c0f7f9c673b11
Cr-Commit-Position: refs/heads/master@{#32439}

Powered by Google App Engine
This is Rietveld 408576698