Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1488933002: Misc fixes for gn builds with VS 2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable warning 4267 which is the VC++ 2015 4244 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | google_apis/gcm/base/mcs_util_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/ccache.gni") 9 import("//build/toolchain/ccache.gni")
10 10
(...skipping 723 matching lines...) Expand 10 before | Expand all | Expand 10 after
734 # use setjmp/longjmp for e.g. JPEG decode error handling, which means we 734 # use setjmp/longjmp for e.g. JPEG decode error handling, which means we
735 # have to turn off this warning (and be careful about how object 735 # have to turn off this warning (and be careful about how object
736 # destruction happens in such cases). 736 # destruction happens in such cases).
737 "/wd4611", 737 "/wd4611",
738 738
739 # Warnings to evaluate and possibly fix/reenable later: 739 # Warnings to evaluate and possibly fix/reenable later:
740 740
741 "/wd4100", # Unreferenced formal function parameter. 741 "/wd4100", # Unreferenced formal function parameter.
742 "/wd4121", # Alignment of a member was sensitive to packing. 742 "/wd4121", # Alignment of a member was sensitive to packing.
743 "/wd4244", # Conversion: possible loss of data. 743 "/wd4244", # Conversion: possible loss of data.
744 "/wd4267", # Conversion: possible loss of data.
brettw 2015/12/02 18:33:59 We don't want to add this globally. jschuh spent a
744 "/wd4481", # Nonstandard extension: override specifier. 745 "/wd4481", # Nonstandard extension: override specifier.
745 "/wd4505", # Unreferenced local function has been removed. 746 "/wd4505", # Unreferenced local function has been removed.
746 "/wd4510", # Default constructor could not be generated. 747 "/wd4510", # Default constructor could not be generated.
747 "/wd4512", # Assignment operator could not be generated. 748 "/wd4512", # Assignment operator could not be generated.
748 "/wd4610", # Class can never be instantiated, constructor required. 749 "/wd4610", # Class can never be instantiated, constructor required.
749 "/wd4838", # Narrowing conversion. Doesn't seem to be very useful. 750 "/wd4838", # Narrowing conversion. Doesn't seem to be very useful.
750 "/wd4995", # 'X': name was marked as #pragma deprecated 751 "/wd4995", # 'X': name was marked as #pragma deprecated
751 "/wd4996", # Deprecated function warning. 752 "/wd4996", # Deprecated function warning.
752 753
753 # These are variable shadowing warnings that are new in VS2015. We 754 # These are variable shadowing warnings that are new in VS2015. We
(...skipping 560 matching lines...) Expand 10 before | Expand all | Expand 10 after
1314 if (symbol_level == 0) { 1315 if (symbol_level == 0) {
1315 configs = [ ":no_symbols" ] 1316 configs = [ ":no_symbols" ]
1316 } else if (symbol_level == 1) { 1317 } else if (symbol_level == 1) {
1317 configs = [ ":minimal_symbols" ] 1318 configs = [ ":minimal_symbols" ]
1318 } else if (symbol_level == 2) { 1319 } else if (symbol_level == 2) {
1319 configs = [ ":symbols" ] 1320 configs = [ ":symbols" ]
1320 } else { 1321 } else {
1321 assert(false) 1322 assert(false)
1322 } 1323 }
1323 } 1324 }
OLDNEW
« no previous file with comments | « no previous file | google_apis/gcm/base/mcs_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698