Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1488893003: Fix size_t truncations in media for 64-bit VS 2015 (Closed)

Created:
5 years ago by brucedawson
Modified:
5 years ago
Reviewers:
miu
CC:
chromium-reviews, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix size_t truncations in media for 64-bit VS 2015 These changes are enough to get the media portions of Chromium building with VS 2015 in 64-bit gn builds. The changes are all to fix warnings about truncation from size_t to smaller types. R=miu@chromium.org BUG=440500 Committed: https://crrev.com/28911d2c106dab15ca44618a45ba3d9f0385e0bd Cr-Commit-Position: refs/heads/master@{#362331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M media/cast/net/rtcp/rtcp_builder_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M media/cast/net/rtp/packet_storage_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brucedawson
PTAL. The surprising indenting in packet_storage_unittest.cc is straight out of git cl format. I don't ...
5 years ago (2015-12-01 01:17:35 UTC) #1
miu
lgtm Yeah, I'm not a fan of the newly-forced indenting rules (especially since nobody consulted ...
5 years ago (2015-12-01 03:13:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488893003/1
5 years ago (2015-12-01 03:13:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 03:29:12 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-01 03:30:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28911d2c106dab15ca44618a45ba3d9f0385e0bd
Cr-Commit-Position: refs/heads/master@{#362331}

Powered by Google App Engine
This is Rietveld 408576698