content/test/data/accessibility/html/input-checkbox-in-menu.html - Issue 1488893002: Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have a mixed state.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/accessibility/html/input-checkbox-in-menu.html

Issue 1488893002: Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have a mixed state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test for menu checkboxes and removed indeterminate state. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/accessibility/browser_accessibility_win.cc ('K') | « content/test/data/accessibility/html/input-checkbox-expected-win.txt ('k') | content/test/data/accessibility/html/input-checkbox-in-menu-expected-android.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!--	1 <!--

2 @WIN-ALLOW:checkable*	2 @WIN-ALLOW:checkable*

3 @WIN-ALLOW:ia2_hypertext=*	3 @WIN-ALLOW:ia2_hypertext=*

4 @WIN-ALLOW:IA2_STATE_CHECKABLE*	4 @WIN-ALLOW:IA2_STATE_CHECKABLE*

	5 @WIN-ALLOW:MIXED

5 @WIN-ALLOW:xml-roles:*	6 @WIN-ALLOW:xml-roles:*

6 -->	7 -->

7 <html>	8 <html>

8 <body>	9 <body>

9 <menu type="list">	10 <menu type="list">

10 <label><input type="checkbox" value="checked1">CheckBox1</label>	11 <label><input type="checkbox" value="Checked1">Checkbox1</label>

11 </menu>	12 <label><input type="checkbox" checked value="Checked2">Checkbox2</label>

12 <div role="menu">	13 </menu>

13 <label><input type="checkbox" value="checked2">CheckBox2</label>	14 <div role="menu">

14 </div>	15 <label><input type="checkbox" checked value="Checked3">Checkbox3</label>

	16 <label><input type="checkbox" id="checkbox4" value="Checked4">Checkbox4</lab el>

	17 </div>

	18

	19 <script>

	20 var checkbox4 = document.getElementById('checkbox4');

	21 checkbox4.indeterminate = true;

	22 </script>

15 </body>	23 </body>

16 </html>	24 </html>

OLD	NEW