Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1488873004: [bootstrapper] no longer use outdated contexts list. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[bootstrapper] no longer use outdated contexts list. We currently use the outdated contexts list provided by the serializer to update the receiver (the global proxy) in script contexts. However, this is not actually necessary, since the global proxy is passed to the deserializer and replaced as we deserialize. Originally, the outdated contexts list is to update the global object field in contexts. This was necessary since at the time the deserializer creates the native context, the global object has not yet been created. But the global proxy already exists. R=bmeurer@chromium.org Committed: https://crrev.com/564a20867642ed503c315c72f5ac38dc95712890 Cr-Commit-Position: refs/heads/master@{#32483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -114 lines) Patch
M src/bootstrapper.cc View 5 chunks +4 lines, -27 lines 0 comments Download
M src/snapshot/serialize.h View 3 chunks +2 lines, -7 lines 0 comments Download
M src/snapshot/serialize.cc View 4 chunks +1 line, -45 lines 0 comments Download
M src/snapshot/snapshot.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/snapshot/snapshot-common.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M test/cctest/test-serialize.cc View 4 chunks +10 lines, -29 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Yang
5 years ago (2015-12-01 14:42:49 UTC) #1
Benedikt Meurer
LGTM.
5 years ago (2015-12-01 15:11:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488873004/1
5 years ago (2015-12-01 16:05:34 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/12564)
5 years ago (2015-12-01 22:09:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488873004/1
5 years ago (2015-12-01 23:03:53 UTC) #8
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
5 years ago (2015-12-01 23:30:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488873004/1
5 years ago (2015-12-01 23:32:51 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 23:36:00 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-01 23:42:06 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/564a20867642ed503c315c72f5ac38dc95712890
Cr-Commit-Position: refs/heads/master@{#32483}

Powered by Google App Engine
This is Rietveld 408576698