src/runtime/runtime-object.cc - Issue 1488873003: [proxies] Implement Symbol/DONT_ENUM filtering for GetKeys()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-object.cc

Issue 1488873003: [proxies] Implement Symbol/DONT_ENUM filtering for GetKeys() (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: moved filtering into KeyAccumulator Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-object.cc

diff --git a/src/runtime/runtime-object.cc b/src/runtime/runtime-object.cc

index 26a55ac75b36489e84028946e265318abce52fbb..3493eb346c230f8759afad47a0bc883b060f8acb 100644

--- a/src/runtime/runtime-object.cc

+++ b/src/runtime/runtime-object.cc

@@ -977,8 +977,7 @@ RUNTIME_FUNCTION(Runtime_GetIndexedInterceptorElementNames) {

RUNTIME_FUNCTION(Runtime_OwnKeys) {

HandleScope scope(isolate);

DCHECK(args.length() == 1);

- CONVERT_ARG_CHECKED(JSObject, raw_object, 0);

- Handle<JSObject> object(raw_object);

+ CONVERT_ARG_HANDLE_CHECKED(JSReceiver, object, 0);

Handle<FixedArray> contents;

ASSIGN_RETURN_FAILURE_ON_EXCEPTION(

« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/harmony/proxies-keys.js » ('j') | no next file with comments »