src/key-accumulator.h - Issue 1488873003: [proxies] Implement Symbol/DONT_ENUM filtering for GetKeys()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/key-accumulator.h

Issue 1488873003: [proxies] Implement Symbol/DONT_ENUM filtering for GetKeys() (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: moved filtering into KeyAccumulator Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/key-accumulator.h

diff --git a/src/key-accumulator.h b/src/key-accumulator.h

index 47a1a6486bf200b2df8f7f74c6f71dd26a456219..9c44df4fb15999eee7070c51e821bfd6a01bf941 100644

--- a/src/key-accumulator.h

+++ b/src/key-accumulator.h

@@ -44,7 +44,8 @@ class KeyAccumulator final BASE_EMBEDDED {

void AddKeys(Handle<JSObject> array,

AddKeyConversion convert = DO_NOT_CONVERT);

void AddKeysFromProxy(Handle<JSObject> array);

- void AddKeysFromProxy(Handle<FixedArray> keys);

+ bool AddKeysFromProxy(Handle<JSProxy> proxy, Handle<FixedArray> keys,

+ KeyFilter filter, Enumerability enum_policy);

void AddElementKeysFromInterceptor(Handle<JSObject> array);

// Jump to the next level, pushing the current |levelLength_| to

// |levelLengths_| and adding a new list to |elements_|.

« no previous file with comments | « src/js/v8natives.js ('k') | src/key-accumulator.cc » ('j') | no next file with comments »