Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1488873002: Revert "Treat '...' as a non-parent path component outside of Windows." (Closed)

Created:
5 years ago by davidben
Modified:
5 years ago
Reviewers:
Mark Mentovai, jschuh
CC:
chromium-reviews, tzik, vmpstr+watch_chromium.org, jam, nhiroki, darin-cc_chromium.org, blink-reviews, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Treat '...' as a non-parent path component outside of Windows." This reverts commit f61e0a571a76b94eb5ce059ea25babff6a2bb3a3 (https://codereview.chromium.org/1469153006). It broke some Blink tests as FilePath::ReferencesParent is also used in things relating to the HTML FileSystem API. Ideally, that API should be immune to bizarre Windows-isms and use a different notion of FilePath from the platform FilePath (which is sensitive to bizarre Windows-ism and others). But that'll require some work to disentangle. In the meantime, revert the problematic change so the tests pass. BUG=464760, 563588 TBR=mark@chromium.org,jschuh@chromium.org Committed: https://crrev.com/19011ca7eb79a4a382993031bb549d06dd0fbd27 Cr-Commit-Position: refs/heads/master@{#362362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -26 lines) Patch
M base/files/file_path.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M base/files/file_path_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
TBR since this is a revert, though I want to wait for try bots to ...
5 years ago (2015-12-01 01:00:26 UTC) #1
Mark Mentovai
LGTM
5 years ago (2015-12-01 02:01:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488873002/1
5 years ago (2015-12-01 06:39:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 06:46:08 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-01 06:46:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19011ca7eb79a4a382993031bb549d06dd0fbd27
Cr-Commit-Position: refs/heads/master@{#362362}

Powered by Google App Engine
This is Rietveld 408576698