Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: build/config/win/BUILD.gn

Issue 1488853003: GN: Do not pass /safeseh to ml64.exe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/win/BUILD.gn
diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn
index dec7a5abfb42305d2e0b44e85b3e36ec34a49dd1..254000bca2508d03722d19772680bf0e37047931 100644
--- a/build/config/win/BUILD.gn
+++ b/build/config/win/BUILD.gn
@@ -12,14 +12,16 @@ assert(is_win)
# is applied to all targets. It is here to separate out the logic that is
# Windows-only.
config("compiler") {
- asmflags = [
- # When /safeseh is specified, the linker will only produce an image if it
- # can also produce a table of the image's safe exception handlers. This
- # table specifies for the operating system which exception handlers are
- # valid for the image. Note that /SAFESEH isn't accepted on the command
- # line, only /safeseh.
- "/safeseh",
- ]
+ if (current_cpu == "x86") {
scottmg 2015/12/01 21:44:44 Are target_cpu and current_cpu the same here?
Roland McGrath 2015/12/01 21:49:23 Not necessarily. current_cpu is the proper one to
scottmg 2015/12/01 21:49:31 From `gn help target_cpu` and `gn help current_cpu
+ asmflags = [
+ # When /safeseh is specified, the linker will only produce an image if it
+ # can also produce a table of the image's safe exception handlers. This
+ # table specifies for the operating system which exception handlers are
+ # valid for the image. Note that /SAFESEH isn't accepted on the command
+ # line, only /safeseh. This is only accepted by ml.exe, not ml64.exe.
+ "/safeseh",
+ ]
+ }
cflags = [
"/Gy", # Enable function-level linking.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698