Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1298)

Unified Diff: test/intl/collator/protected-icu-internals.js

Issue 148883002: Synchronize with r15594. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/intl/collator/property-override.js ('k') | test/intl/collator/resolved-options-is-method.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/intl/collator/protected-icu-internals.js
diff --git a/test/mjsunit/regress/regress-237617.js b/test/intl/collator/protected-icu-internals.js
similarity index 72%
copy from test/mjsunit/regress/regress-237617.js
copy to test/intl/collator/protected-icu-internals.js
index dabf828ae8bbfa3223e56664a97780098e6c5e3e..7acd35e45464bd248b0fc7fa54b83c27588a127c 100644
--- a/test/mjsunit/regress/regress-237617.js
+++ b/test/intl/collator/protected-icu-internals.js
@@ -25,19 +25,25 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-"use strict"
+// Internal object we got from native code should not be writable,
+// configurable or enumerable. One can still change its public properties, but
+// we don't use them to do actual work.
-function f() {
- throw new Error("test stack");
-}
+var collator = new Intl.Collator([]);
+
+// Direct write should fail.
+collator.collator = {'zzz':'some random object'};
-var error_stack = "";
+assertFalse(collator.collator.hasOwnProperty('zzz'));
+
+// Try redefining the property.
+var didThrow = false;
try {
- f.call(null);
-} catch (e) {
- error_stack = e.stack;
+ Object.defineProperty(collator, 'collator', {value: undefined});
+} catch(e) {
+ didThrow = true;
}
+assertTrue(didThrow);
-assertTrue(error_stack.indexOf("test stack") > 0);
-assertTrue(error_stack.indexOf("illegal") < 0);
-
+// Try deleting the property.
+assertFalse(delete collator.collator);
« no previous file with comments | « test/intl/collator/property-override.js ('k') | test/intl/collator/resolved-options-is-method.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698