CMake, include/: changes to make fiddle 2.0 better

CMake, include/:  changes to make fiddle 2.0 better

cmake: remove unused directories from skia.h / ${public_includes}

SkPreConfig.h:  work around buggy `#ifdef linux`

include:  guard many platform-specific headers
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot

Committed: https://skia.googlesource.com/skia/+/0cbe7ee765cf72f15e6ca10b308676aa077fb3e2

[hal.canary, 2015-11-30 23:13:31]

Description was changed from

==========
CMake, include/:  changes to make fiddle 2.0 better

cmake: remove unused directories from skia.h / ${public_includes}

SkPreConfig.h:  work around buggy `#ifdef linux`

include:  guard many platform-specific headers
==========

to

==========
CMake, include/:  changes to make fiddle 2.0 better

cmake: remove unused directories from skia.h / ${public_includes}

SkPreConfig.h:  work around buggy `#ifdef linux`

include:  guard many platform-specific headers
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot
==========

[hal.canary, 2015-11-30 23:13:48]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-30 23:14:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488813002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488813002/1

[commit-bot: I haz the power, 2015-11-30 23:26:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-30 23:26:46]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2015-12-01 12:41:56]

halcanary@google.com changed reviewers:
+ jcgregorio@google.com, mtklein@google.com, reed@google.com

[hal.canary, 2015-12-01 12:41:56]

PTAL

reed@: api only
mtklein@: cmake

[reed1, 2015-12-01 14:42:23]

api lgtm w/ nits

https://codereview.chromium.org/1488813002/diff/1/include/utils/win/SkAutoCoI...
File include/utils/win/SkAutoCoInitialize.h (right):

https://codereview.chromium.org/1488813002/diff/1/include/utils/win/SkAutoCoI...
include/utils/win/SkAutoCoInitialize.h:12: #ifdef SK_BUILD_FOR_WIN
nit: whitespace between these two?

https://codereview.chromium.org/1488813002/diff/1/include/utils/win/SkIStream.h
File include/utils/win/SkIStream.h (right):

https://codereview.chromium.org/1488813002/diff/1/include/utils/win/SkIStream...
include/utils/win/SkIStream.h:14: #ifdef SK_BUILD_FOR_WIN
nit: ws

[hal.canary, 2015-12-01 16:43:03]

https://codereview.chromium.org/1488813002/diff/1/include/utils/win/SkAutoCoI...
File include/utils/win/SkAutoCoInitialize.h (right):

https://codereview.chromium.org/1488813002/diff/1/include/utils/win/SkAutoCoI...
include/utils/win/SkAutoCoInitialize.h:12: #ifdef SK_BUILD_FOR_WIN
On 2015/12/01 at 14:42:23, reed1 wrote:
> nit: whitespace between these two?

Done.

https://codereview.chromium.org/1488813002/diff/1/include/utils/win/SkIStream.h
File include/utils/win/SkIStream.h (right):

https://codereview.chromium.org/1488813002/diff/1/include/utils/win/SkIStream...
include/utils/win/SkIStream.h:14: #ifdef SK_BUILD_FOR_WIN
On 2015/12/01 at 14:42:23, reed1 wrote:
> nit: ws

Done.

[jcgregorio, 2015-12-01 16:44:00]

lgtm

[hal.canary, 2015-12-01 16:44:20]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-12-01 16:44:20]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1488813002/#ps20001
(title: "whitespace change for reed@")

[commit-bot: I haz the power, 2015-12-01 16:44:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488813002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488813002/20001

[commit-bot: I haz the power, 2015-12-01 17:02:51]

Description was changed from

==========
CMake, include/:  changes to make fiddle 2.0 better

cmake: remove unused directories from skia.h / ${public_includes}

SkPreConfig.h:  work around buggy `#ifdef linux`

include:  guard many platform-specific headers
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
CMake, include/:  changes to make fiddle 2.0 better

cmake: remove unused directories from skia.h / ${public_includes}

SkPreConfig.h:  work around buggy `#ifdef linux`

include:  guard many platform-specific headers
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/0cbe7ee765cf72f15e6ca10b308676aa077fb3e2
==========

[commit-bot: I haz the power, 2015-12-01 17:02:51]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0cbe7ee765cf72f15e6ca10b308676aa077fb3e2