Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1488803002: Make init*Event() arguments nullable where appropriate (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make init*Event() arguments nullable where appropriate Because these methods have [LegacyInterfaceTypeChecking], this does not change the generated code, but it will limit the impact of dropping [LegacyInterfaceTypeChecking]. Only initKeyboardEvent() appears to have a spec: https://w3c.github.io/uievents/#idl-interface-KeyboardEvent-initializers For the others, the nullability matches that of the *Event member. BUG=561338 R=rbyers@chromium.org Committed: https://crrev.com/d29a3f55232d9c7de25d182f7ae0152325c533e4 Cr-Commit-Position: refs/heads/master@{#362470}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/events/KeyboardEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/MutationEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/TextEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/TouchEvent.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
philipj_slow
5 years ago (2015-11-30 23:01:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488803002/1
5 years ago (2015-11-30 23:07:40 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 01:40:12 UTC) #5
Rick Byers
LGTM
5 years ago (2015-12-01 16:52:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488803002/1
5 years ago (2015-12-01 19:05:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 19:21:12 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-01 19:22:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d29a3f55232d9c7de25d182f7ae0152325c533e4
Cr-Commit-Position: refs/heads/master@{#362470}

Powered by Google App Engine
This is Rietveld 408576698