Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 14888: Code regions (Closed)

Created:
12 years ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Added support in the profiler for creating 'regions' that cover part of the generated code. These can be used by the profiler to categorize the ticks that occur within generated code and thereby show more detailed information about where time is spent in generated code. For instance, this is what the profiler displayed for a simple regexp benchmark with irregexp-native before: [JavaScript]: total nonlib name 87.2% 87.2% RegExp: (?:\w*\W+)* This is what we can display now: [JavaScript]: total nonlib name 87.2% 87.2% RegExp: (?:\w*\W+)* - 53.0% 56.7% BranchOrBacktrack - 14.9% 59.8% CheckCharacterLT - 13.7% 20.4% CheckStackLimit - 6.7% 6.7% SafeCall - 2.7% 7.0% CheckCharacterGT - 2.4% 2.4% SafeReturn - 2.1% 2.1% LoadCurrentCharacter - 1.8% 1.8% PushRegister - 0.9% 0.9% PopRegister - 0.9% 0.9% AdvanceRegister - 0.3% 0.3% PopCurrentPosition - 0.3% 0.3% CheckGreedyLoop - 0.0% 20.4% PushBacktrack - 0.0% 22.3% CheckCharacter - 0.0% 2.4% IfRegisterLT

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -5 lines) Patch
M src/assembler.h View 1 chunk +16 lines, -0 lines 2 comments Download
M src/assembler-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/globals.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/log.h View 1 chunk +6 lines, -0 lines 1 comment Download
M src/log.cc View 3 chunks +40 lines, -0 lines 0 comments Download
M src/macro-assembler-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/tickprocessor.py View 8 chunks +108 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Christian Plesner Hansen
12 years ago (2008-12-19 12:15:03 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/14888/diff/1/3 File src/assembler.h (right): http://codereview.chromium.org/14888/diff/1/3#newcode390 Line 390: inline CodeRegion(Assembler* assm, const char *name) : ...
12 years ago (2008-12-19 12:44:01 UTC) #2
Christian Plesner Hansen
12 years ago (2008-12-19 13:22:06 UTC) #3
http://codereview.chromium.org/14888/diff/1/3
File src/assembler.h (right):

http://codereview.chromium.org/14888/diff/1/3#newcode390
Line 390: inline CodeRegion(Assembler* assm, const char *name) : assm_(assm) {
I doubt is: 'asm' is a keyword.

Powered by Google App Engine
This is Rietveld 408576698