Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1488793002: Tweak Document.createElement for better inlining (Closed)

Created:
5 years ago by sra1
Modified:
5 years ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tweak Document.createElement for better inlining Single return statement lets the current optimizer inline the function. R=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/0b9cdccf1c9046de657623658deafebf50d0da17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -20 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +6 lines, -10 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Document.darttemplate View 2 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
5 years ago (2015-11-30 21:26:23 UTC) #2
Alan Knight
lgtm
5 years ago (2015-11-30 21:32:04 UTC) #3
sra1
5 years ago (2015-11-30 21:36:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0b9cdccf1c9046de657623658deafebf50d0da17 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698