Clean up promises and fix an edge case bug

Clean up promises and fix an edge case bug

This patch builds on previous Promise spec compliance work by
cleaning out some old code which existed to support
Promise.prototype.chain, rephrasing some code to correspond more
closely to the specification, and removing some incorrect brand
checking. A test is added for a bug in an edge case which was fixed.

R=rossberg
BUG=v8:3641
LOG=Y

Committed: https://crrev.com/1deb89c8fd3cb69714ae0a24e3b5a4e78f6b73b4
Cr-Commit-Position: refs/heads/master@{#32627}

[Dan Ehrenberg, 2015-12-01 17:34:27]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-01 17:34:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488783002/40001

[commit-bot: I haz the power, 2015-12-01 17:46:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-01 17:46:12]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/10857)

[Dan Ehrenberg, 2015-12-01 23:33:52]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-01 23:35:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488783002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488783002/60001

[commit-bot: I haz the power, 2015-12-02 00:24:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 00:24:47]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2015-12-02 16:01:42]

Description was changed from

==========
Clean up promises and fix an edge case bug

This patch builds on previous Promise spec compliance work by
cleaning out some old code which existed to support
Promise.prototype.chain, rephrasing some code to correspond more
closely to the specification, and removing some incorrect brand
checking. A test is added for a bug in an edge case which was fixed.

Note, this is an early, broken version

R=rossberg
BUG=v8:3641
LOG=Y
==========

to

==========
Clean up promises and fix an edge case bug

This patch builds on previous Promise spec compliance work by
cleaning out some old code which existed to support
Promise.prototype.chain, rephrasing some code to correspond more
closely to the specification, and removing some incorrect brand
checking. A test is added for a bug in an edge case which was fixed.

R=rossberg
BUG=v8:3641
LOG=Y
==========

[Dan Ehrenberg, 2015-12-03 15:34:58]

littledan@chromium.org changed reviewers:
+ caitpotter88@gmail.com

[rossberg, 2015-12-04 13:53:11]

lgtm

[Dan Ehrenberg, 2015-12-04 18:25:47]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2015-12-04 18:25:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488783002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488783002/60001

[commit-bot: I haz the power, 2015-12-04 18:55:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-04 18:56:25]

Description was changed from

==========
Clean up promises and fix an edge case bug

This patch builds on previous Promise spec compliance work by
cleaning out some old code which existed to support
Promise.prototype.chain, rephrasing some code to correspond more
closely to the specification, and removing some incorrect brand
checking. A test is added for a bug in an edge case which was fixed.

R=rossberg
BUG=v8:3641
LOG=Y
==========

to

==========
Clean up promises and fix an edge case bug

This patch builds on previous Promise spec compliance work by
cleaning out some old code which existed to support
Promise.prototype.chain, rephrasing some code to correspond more
closely to the specification, and removing some incorrect brand
checking. A test is added for a bug in an edge case which was fixed.

R=rossberg
BUG=v8:3641
LOG=Y

Committed: https://crrev.com/1deb89c8fd3cb69714ae0a24e3b5a4e78f6b73b4
Cr-Commit-Position: refs/heads/master@{#32627}
==========

[commit-bot: I haz the power, 2015-12-04 18:56:26]

Patchset 4 (id:??) landed as
https://crrev.com/1deb89c8fd3cb69714ae0a24e3b5a4e78f6b73b4
Cr-Commit-Position: refs/heads/master@{#32627}

[Michael Achenbach, 2015-12-05 08:50:53]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1501763004/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

Please request rebase upstream first..

[Dan Ehrenberg, 2015-12-08 01:31:49]

On 2015/12/05 at 08:50:53, machenbach wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1501763004/ by machenbach@chromium.org.
> 
> The reason for reverting is: [Sheriff] Breaks layout tests:
>
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...
> 
> Please request rebase upstream first..

Are you sure that this patch was responsible for the breakage? I tried
re-landing my patch and running some of these layout tests that failed, and all
of them passed.

[adamk, 2015-12-08 16:42:05]

On 2015/12/08 01:31:49, Dan Ehrenberg wrote:
> On 2015/12/05 at 08:50:53, machenbach wrote:
> > A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/1501763004/ by mailto:machenbach@chromium.org.
> > 
> > The reason for reverting is: [Sheriff] Breaks layout tests:
> >
>
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...
> > 
> > Please request rebase upstream first..
> 
> Are you sure that this patch was responsible for the breakage? I tried
> re-landing my patch and running some of these layout tests that failed, and
all
> of them passed.

These three tests all sound pretty related:

inspector/sources/debugger-step/debugger-step-into-async2.html
inspector/sources/debugger/promise-events.html
inspector/sources/debugger-async/async-callstack-promises.html

Are those the ones you ran? It looks like they might actually be failing, too,
though it's hard to tell from the output without reading the tests:
https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_6...