Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 1488773004: VM: More read-only handles for constant null-objects/-instances. (Closed)

Created:
5 years ago by Florian Schneider
Modified:
5 years ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: More read-only handles for constant null-objects/-instances. Use Object::null_## for null-constants where possible. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/5f073e7be0a88292765d610b4d823126e1f9eafc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M runtime/vm/parser.cc View 10 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
5 years ago (2015-12-01 13:12:21 UTC) #2
siva
lgtm
5 years ago (2015-12-02 02:21:21 UTC) #3
Florian Schneider
5 years ago (2015-12-02 10:36:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5f073e7be0a88292765d610b4d823126e1f9eafc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698