Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8818)

Unified Diff: chrome/browser/password_manager/password_manager_browsertest.cc

Issue 1488763003: [Password Manager] Switch password manager code to use "base/feature_list.h". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses nit. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc
index 5cb9c096876986d0de217a6a51aa3043cecf23b9..e9b070deecda14b8b22fd46cc533e97791ed5023 100644
--- a/chrome/browser/password_manager/password_manager_browsertest.cc
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc
@@ -36,6 +36,7 @@
#include "components/password_manager/content/browser/content_password_manager_driver_factory.h"
#include "components/password_manager/core/browser/login_model.h"
#include "components/password_manager/core/browser/test_password_store.h"
+#include "components/password_manager/core/common/password_manager_features.h"
#include "components/password_manager/core/common/password_manager_switches.h"
#include "components/version_info/version_info.h"
#include "content/public/browser/navigation_controller.h"
@@ -1191,9 +1192,12 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
NavigateToFile("/password/password_form.html");
- // Add the enable-automatic-password-saving switch.
- base::CommandLine::ForCurrentProcess()->AppendSwitch(
- password_manager::switches::kEnableAutomaticPasswordSaving);
+ // Add the enable-automatic-password-saving feature.
+ base::FeatureList::ClearInstanceForTesting();
+ scoped_ptr<base::FeatureList> feature_list(new base::FeatureList);
+ feature_list->InitializeFromCommandLine(
+ password_manager::features::kEnableAutomaticPasswordSaving.name, "");
+ base::FeatureList::SetInstance(std::move(feature_list));
// Fill a form and submit through a <input type="submit"> button.
NavigationObserver observer(WebContents());

Powered by Google App Engine
This is Rietveld 408576698