Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2195)

Unified Diff: chrome/browser/about_flags.cc

Issue 1488763003: [Password Manager] Switch password manager code to use "base/feature_list.h". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses nit. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 0b32f7814a837f569a923fbe8abce91955c43e52..67d6b8fc17b7243c7fd5b3c1433aa5e2d106dfb6 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -41,6 +41,7 @@
#include "components/nacl/common/nacl_switches.h"
#include "components/offline_pages/offline_page_switches.h"
#include "components/omnibox/browser/omnibox_switches.h"
+#include "components/password_manager/core/common/password_manager_features.h"
#include "components/password_manager/core/common/password_manager_switches.h"
#include "components/proximity_auth/switches.h"
#include "components/search/search_switches.h"
@@ -1030,8 +1031,8 @@ const FeatureEntry kFeatureEntries[] = {
IDS_FLAGS_AUTOMATIC_PASSWORD_SAVING_NAME,
IDS_FLAGS_AUTOMATIC_PASSWORD_SAVING_DESCRIPTION,
kOsDesktop,
- SINGLE_VALUE_TYPE(
- password_manager::switches::kEnableAutomaticPasswordSaving)},
+ FEATURE_VALUE_TYPE(
+ password_manager::features::kEnableAutomaticPasswordSaving)},
{"password-manager-reauthentication",
IDS_FLAGS_PASSWORD_MANAGER_REAUTHENTICATION_NAME,
IDS_FLAGS_PASSWORD_MANAGER_REAUTHENTICATION_DESCRIPTION,
@@ -1042,13 +1043,14 @@ const FeatureEntry kFeatureEntries[] = {
IDS_FLAGS_PASSWORD_CHANGE_SUPPORT_NAME,
IDS_FLAGS_PASSWORD_CHANGE_SUPPORT_DESCRIPTION,
kOsMac,
- SINGLE_VALUE_TYPE(
- password_manager::switches::kEnablePasswordChangeSupport)},
+ FEATURE_VALUE_TYPE(
+ password_manager::features::kEnablePasswordChangeSupport)},
{"enable-password-force-saving",
IDS_FLAGS_PASSWORD_FORCE_SAVING_NAME,
IDS_FLAGS_PASSWORD_FORCE_SAVING_DESCRIPTION,
kOsAll,
- SINGLE_VALUE_TYPE(password_manager::switches::kEnablePasswordForceSaving)},
+ FEATURE_VALUE_TYPE(
+ password_manager::features::kEnablePasswordForceSaving)},
{"enable-affiliation-based-matching",
IDS_FLAGS_AFFILIATION_BASED_MATCHING_NAME,
IDS_FLAGS_AFFILIATION_BASED_MATCHING_DESCRIPTION,
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698