chrome/browser/password_manager/chrome_password_manager_client.cc - Issue 1488763003: [Password Manager] Switch password manager code to use "base/feature_list.h".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1488763003: [Password Manager] Switch password manager code to use "base/feature_list.h". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/password_manager/chrome_password_manager_client_unittest.cc » ('j') | components/password_manager/core/common/password_manager_features.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc

index 9fb2881a7712970b80c02edb7e544a0750d57f71..664d44e1504774d2e1480d9ed73513e876a5a3ac 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc

@@ -41,6 +41,7 @@

#include "components/password_manager/core/browser/password_manager_settings_migration_experiment.h"

#include "components/password_manager/core/browser/password_manager_util.h"

#include "components/password_manager/core/common/credential_manager_types.h"

+#include "components/password_manager/core/common/password_manager_features.h"

#include "components/password_manager/core/common/password_manager_pref_names.h"

#include "components/password_manager/core/common/password_manager_switches.h"

#include "components/password_manager/sync/browser/password_sync_util.h"

@@ -159,8 +160,8 @@ ChromePasswordManagerClient::ChromePasswordManagerClient(

ChromePasswordManagerClient::~ChromePasswordManagerClient() {}

bool ChromePasswordManagerClient::IsAutomaticPasswordSavingEnabled() const {

- return base::CommandLine::ForCurrentProcess()->HasSwitch(

- password_manager::switches::kEnableAutomaticPasswordSaving) &&

+ return base::FeatureList::IsEnabled(

+ password_manager::features::kEnableAutomaticPasswordSaving) &&

chrome::GetChannel() == version_info::Channel::UNKNOWN;

}