Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1488763003: [Password Manager] Switch password manager code to use "base/feature_list.h". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses nit. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/chrome_password_manager_client.h" 5 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 23 matching lines...) Expand all
34 #include "components/password_manager/content/common/credential_manager_messages .h" 34 #include "components/password_manager/content/common/credential_manager_messages .h"
35 #include "components/password_manager/core/browser/browser_save_password_progres s_logger.h" 35 #include "components/password_manager/core/browser/browser_save_password_progres s_logger.h"
36 #include "components/password_manager/core/browser/log_manager.h" 36 #include "components/password_manager/core/browser/log_manager.h"
37 #include "components/password_manager/core/browser/log_receiver.h" 37 #include "components/password_manager/core/browser/log_receiver.h"
38 #include "components/password_manager/core/browser/password_form_manager.h" 38 #include "components/password_manager/core/browser/password_form_manager.h"
39 #include "components/password_manager/core/browser/password_manager_internals_se rvice.h" 39 #include "components/password_manager/core/browser/password_manager_internals_se rvice.h"
40 #include "components/password_manager/core/browser/password_manager_metrics_util .h" 40 #include "components/password_manager/core/browser/password_manager_metrics_util .h"
41 #include "components/password_manager/core/browser/password_manager_settings_mig ration_experiment.h" 41 #include "components/password_manager/core/browser/password_manager_settings_mig ration_experiment.h"
42 #include "components/password_manager/core/browser/password_manager_util.h" 42 #include "components/password_manager/core/browser/password_manager_util.h"
43 #include "components/password_manager/core/common/credential_manager_types.h" 43 #include "components/password_manager/core/common/credential_manager_types.h"
44 #include "components/password_manager/core/common/password_manager_features.h"
44 #include "components/password_manager/core/common/password_manager_pref_names.h" 45 #include "components/password_manager/core/common/password_manager_pref_names.h"
45 #include "components/password_manager/core/common/password_manager_switches.h" 46 #include "components/password_manager/core/common/password_manager_switches.h"
46 #include "components/password_manager/sync/browser/password_sync_util.h" 47 #include "components/password_manager/sync/browser/password_sync_util.h"
47 #include "components/signin/core/browser/signin_manager.h" 48 #include "components/signin/core/browser/signin_manager.h"
48 #include "components/version_info/version_info.h" 49 #include "components/version_info/version_info.h"
49 #include "content/public/browser/navigation_entry.h" 50 #include "content/public/browser/navigation_entry.h"
50 #include "content/public/browser/render_view_host.h" 51 #include "content/public/browser/render_view_host.h"
51 #include "content/public/browser/web_contents.h" 52 #include "content/public/browser/web_contents.h"
52 #include "google_apis/gaia/gaia_urls.h" 53 #include "google_apis/gaia/gaia_urls.h"
53 #include "net/base/url_util.h" 54 #include "net/base/url_util.h"
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 154
154 saving_and_filling_passwords_enabled_.Init( 155 saving_and_filling_passwords_enabled_.Init(
155 password_manager::prefs::kPasswordManagerSavingEnabled, GetPrefs()); 156 password_manager::prefs::kPasswordManagerSavingEnabled, GetPrefs());
156 ReportMetrics(*saving_and_filling_passwords_enabled_, this, profile_); 157 ReportMetrics(*saving_and_filling_passwords_enabled_, this, profile_);
157 driver_factory_->RequestSendLoggingAvailability(); 158 driver_factory_->RequestSendLoggingAvailability();
158 } 159 }
159 160
160 ChromePasswordManagerClient::~ChromePasswordManagerClient() {} 161 ChromePasswordManagerClient::~ChromePasswordManagerClient() {}
161 162
162 bool ChromePasswordManagerClient::IsAutomaticPasswordSavingEnabled() const { 163 bool ChromePasswordManagerClient::IsAutomaticPasswordSavingEnabled() const {
163 return base::CommandLine::ForCurrentProcess()->HasSwitch( 164 return base::FeatureList::IsEnabled(
164 password_manager::switches::kEnableAutomaticPasswordSaving) && 165 password_manager::features::kEnableAutomaticPasswordSaving) &&
165 chrome::GetChannel() == version_info::Channel::UNKNOWN; 166 chrome::GetChannel() == version_info::Channel::UNKNOWN;
166 } 167 }
167 168
168 bool ChromePasswordManagerClient::IsPasswordManagementEnabledForCurrentPage() 169 bool ChromePasswordManagerClient::IsPasswordManagementEnabledForCurrentPage()
169 const { 170 const {
170 DCHECK(web_contents()); 171 DCHECK(web_contents());
171 content::NavigationEntry* entry = 172 content::NavigationEntry* entry =
172 web_contents()->GetController().GetLastCommittedEntry(); 173 web_contents()->GetController().GetLastCommittedEntry();
173 bool is_enabled = false; 174 bool is_enabled = false;
174 if (!entry) { 175 if (!entry) {
(...skipping 359 matching lines...) Expand 10 before | Expand all | Expand 10 after
534 535
535 const password_manager::CredentialsFilter* 536 const password_manager::CredentialsFilter*
536 ChromePasswordManagerClient::GetStoreResultFilter() const { 537 ChromePasswordManagerClient::GetStoreResultFilter() const {
537 return &credentials_filter_; 538 return &credentials_filter_;
538 } 539 }
539 540
540 const password_manager::LogManager* ChromePasswordManagerClient::GetLogManager() 541 const password_manager::LogManager* ChromePasswordManagerClient::GetLogManager()
541 const { 542 const {
542 return log_manager_.get(); 543 return log_manager_.get();
543 } 544 }
OLDNEW
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/password_manager/chrome_password_manager_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698