third_party/WebKit/LayoutTests/fast/canvas/OffScreenCanvas-invalid-args.html - Issue 1488763002: Start an empty interface OffScreenCanvas

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/OffScreenCanvas-invalid-args.html

Issue 1488763002: Start an empty interface OffScreenCanvas (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: better overflow handle and more test cases Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/OffScreenCanvas-constructor-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/canvas/OffScreenCanvas-invalid-args-expected.txt » ('j') | third_party/WebKit/Source/core/html/canvas/OffScreenCanvas.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3 <script>

	4 description("Tests that the OffScreenCanvas can handle invalid arguments");

	5

	6 // Since blink uses signed int internally, this case tests how the constructor

	7 // responses to the arguments that are larger than INT_MAX which would cause
	Justin Novosad 2015/12/03 19:06:11 responses -> responds responses -> responds xidachen 2015/12/03 20:42:22 Done. Show quoted text On 2015/12/03 19:06:11, Justin Novosad wrote: > responses -> responds Done.
	8 // overflow.
	Justin Novosad 2015/12/03 19:06:11 Add: the current implementation is expected to cla Add: the current implementation is expected to clamp. xidachen 2015/12/03 20:42:22 Done. Show quoted text On 2015/12/03 19:06:11, Justin Novosad wrote: > Add: the current implementation is expected to clamp. Done.
	9 var setWidth = Math.pow(2, 31);

	10 var setHeight = Math.pow(2, 31);

	11 var canvas1 = new OffScreenCanvas(setWidth, setHeight);

	12

	13 shouldBe("canvas1.width", "setWidth-1");

	14 shouldBe("canvas1.height", "setHeight-1");

	15

	16 var canvas2 = new OffScreenCanvas(-1, -1);

	17 shouldBe("canvas2.width", "setWidth-1");
	Justin Novosad 2015/12/03 19:06:11 This looks like a bug to me. The WebIDL spec says This looks like a bug to me. The WebIDL spec says this should throw a TypeError: http://www.w3.org/TR/WebIDL/#es-unsigned-long xidachen 2015/12/03 20:42:22 The WebIDL: http://www.w3.org/TR/WebIDL/#es-unsign Show quoted text On 2015/12/03 19:06:11, Justin Novosad wrote: > This looks like a bug to me. The WebIDL spec says this should throw a TypeError: > http://www.w3.org/TR/WebIDL/#es-unsigned-long The WebIDL: http://www.w3.org/TR/WebIDL/#es-unsigned-long says throw TypeError only when [EnforceRange] is specified. If EnforceRange is not used, then it will do width = ToUint32(width), which is essentially modulo 2^32.
	18 shouldBe("canvas2.height", "setHeight-1");

	19

	20 var canvas3 = new OffScreenCanvas(null, null);

	21 shouldBe("canvas3.width", "0");

	22 shouldBe("canvas3.height", "0");

	23

	24 var obj = {Name: "John Doe", Age: 30};

	25 var canvas4 = new OffScreenCanvas(obj, obj);

	26 shouldBe("canvas4.width", "0");

	27 shouldBe("canvas4.height", "0");

	28 </script>
	Justin Novosad 2015/12/03 19:06:11 still missing test coverage for assigning invalid still missing test coverage for assigning invalid values to canvas.width, canvas.height. (attribute setters) xidachen 2015/12/03 20:42:22 Done. Show quoted text On 2015/12/03 19:06:11, Justin Novosad wrote: > still missing test coverage for assigning invalid values to canvas.width, > canvas.height. (attribute setters) Done.
OLD	NEW