Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 148873002: Drop the native FastNewBlockContextStub. (Closed)

Created:
6 years, 10 months ago by Benedikt Meurer
Modified:
6 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Drop the native FastNewBlockContextStub. This code is almost never executed in real world and benchmarks, and there's obviously absolutely no need to have this native code hanging around for no benefit. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -281 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M src/code-stubs.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -63 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Kick all the premature optimizations!
6 years, 10 months ago (2014-01-28 13:34:16 UTC) #1
Sven Panne
lgtm
6 years, 10 months ago (2014-01-28 13:42:26 UTC) #2
Benedikt Meurer
Committed patchset #1 manually as r18880 (presubmit successful).
6 years, 10 months ago (2014-01-28 13:43:13 UTC) #3
Benedikt Meurer
6 years, 10 months ago (2014-01-28 13:44:03 UTC) #4
Message was sent while issue was closed.
For the record: I have a Hydrogen version of this stub, in case this causes
regressions in some important benchmarks.

Powered by Google App Engine
This is Rietveld 408576698