Chromium Code Reviews Chromium Code Reviews
Issue 1488693006:
Fix flaky WebAudio layout tests (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/webaudio/stereopannernode-no-glitch-expected.txt |
| diff --git a/third_party/WebKit/LayoutTests/webaudio/stereopannernode-no-glitch-expected.txt b/third_party/WebKit/LayoutTests/webaudio/stereopannernode-no-glitch-expected.txt |
| index 25ae40bfdb825b95c724d58b7871e696ae70cd05..e5d93ea3669e2bc18964fb59686042f739be429f 100644 |
| --- a/third_party/WebKit/LayoutTests/webaudio/stereopannernode-no-glitch-expected.txt |
| +++ b/third_party/WebKit/LayoutTests/webaudio/stereopannernode-no-glitch-expected.txt |
| @@ -3,16 +3,16 @@ Test if StereoPannerNode producing glitches by crossing zero. |
| On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". |
| -PASS Transition found. (length = 15679) |
| +PASS Transition found between sample #44031 and #59710. |
| PASS Channel #0 has no glitch above the threshold of 0.0005. |
| PASS Channel #1 has no glitch above the threshold of 0.0005. |
| -PASS Channel #0 equals [1.156434465040231,1.1562937736154577,...] with an element-wise tolerance of 1e-7. |
| -PASS Channel #1 equals [0.9876883405951378,0.987710613656166,...] with an element-wise tolerance of 1e-7. |
| -PASS Transition found. (length = 15679) |
| +PASS Channel #0 equals [1.156434465040231,NaN,...] with an element-wise tolerance of 1e-7. |
|
Raymond Toy
2015/12/01 22:14:37
This NaN looks bad, as does the ones below.
hongchan
2015/12/02 18:58:32
Done. It was a stupid mistake. (audiobuffer length
Raymond Toy
2015/12/02 19:37:50
We need to fix that. NaN does not meet an element
|
| +PASS Channel #1 equals [0.9876883405951378,NaN,...] with an element-wise tolerance of 1e-7. |
| +PASS Transition found between sample #44031 and #59710. |
| PASS Channel #0 has no glitch above the threshold of 0.0005. |
| PASS Channel #1 has no glitch above the threshold of 0.0005. |
| -PASS Channel #0 equals [0.9876883405951378,0.987710613656166,...] with an element-wise tolerance of 1e-7. |
| -PASS Channel #1 equals [1.156434465040231,1.156293773615458,...] with an element-wise tolerance of 1e-7. |
| +PASS Channel #0 equals [0.9876883405951378,NaN,...] with an element-wise tolerance of 1e-7. |
| +PASS Channel #1 equals [1.156434465040231,NaN,...] with an element-wise tolerance of 1e-7. |
| PASS successfullyParsed is true |
| TEST COMPLETE |
