content/shell/browser/blink_test_controller.cc - Issue 1488653002: Fix scroll restoration when exiting fullscreen mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/blink_test_controller.cc

Issue 1488653002: Fix scroll restoration when exiting fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Accidentally made will_cause_resize always false in previous cleanup. Fixed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/browser/blink_test_controller.cc

diff --git a/content/shell/browser/blink_test_controller.cc b/content/shell/browser/blink_test_controller.cc

index 623a6677e64e862ee15d86d44ad20b58e96cc2ee..40421e50958345c79e27fd8fc6ef03f1764ae53c 100644

--- a/content/shell/browser/blink_test_controller.cc

+++ b/content/shell/browser/blink_test_controller.cc

@@ -541,7 +541,7 @@ void BlinkTestController::OnTestFinished() {

printer_->PrintImageFooter();

RenderViewHost* render_view_host =

main_window_->web_contents()->GetRenderViewHost();

- main_window_->web_contents()->ExitFullscreen();

+ main_window_->web_contents()->ExitFullscreen(/*will_cause_resize=*/false);

ShellBrowserContext* browser_context =

ShellContentBrowserClient::Get()->browser_context();

« no previous file with comments | « content/public/browser/web_contents_observer.h ('k') | third_party/WebKit/Source/web/FullscreenController.h » ('j') | no next file with comments »