Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc

Issue 1488653002: Fix scroll restoration when exiting fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Accidentally made will_cause_resize always false in previous cleanup. Fixed Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc
diff --git a/chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc b/chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc
index 5804fa13c37d82a904fd75cf243bee311f9dee99..dae3687c0e10e09294553af93b66be1fa7895235 100644
--- a/chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc
+++ b/chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc
@@ -13,6 +13,7 @@
#include "chrome/test/base/browser_with_test_window_test.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/url_constants.h"
+#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
// The FullscreenControllerStateUnitTest unit test suite exhastively tests
@@ -749,6 +750,65 @@ TEST_F(FullscreenControllerStateUnitTest,
EXPECT_TRUE(GetFullscreenController()->IsFullscreenForBrowser());
}
+class FullscreenChangeObserver : public content::WebContentsObserver {
+ public:
+ explicit FullscreenChangeObserver(content::WebContents* web_contents)
+ : WebContentsObserver(web_contents) {
+ }
+
+ MOCK_METHOD2(DidToggleFullscreenModeForTab, void(bool, bool));
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(FullscreenChangeObserver);
+};
+
+// Tests that going from tab fullscreen -> browser fullscreen causes an explicit
+// WasResized to be called on ExitFullscreen while going from tab fullscreen ->
+// Normal does not. This ensures that the Resize message we get in the renderer
+// will have both the fullscreen change and size change in the same message.
+// crbug.com/142427.
+TEST_F(FullscreenControllerStateUnitTest, TabToBrowserFullscreenCausesResize) {
+ AddTab(browser(), GURL(url::kAboutBlankURL));
+ content::WebContents* const tab =
+ browser()->tab_strip_model()->GetWebContentsAt(0);
+
+ FullscreenChangeObserver fullscreenObserver(tab);
+
+ // Go into browser fullscreen, then tab fullscreen. Exiting tab fullscreen
+ // should call WasResized since the fullscreen change won't cause a size
+ // change itself.
+ ASSERT_TRUE(InvokeEvent(TOGGLE_FULLSCREEN));
+ ASSERT_TRUE(InvokeEvent(WINDOW_CHANGE));
+ ASSERT_TRUE(InvokeEvent(TAB_FULLSCREEN_TRUE));
+ ASSERT_TRUE(browser()->window()->IsFullscreen());
+
+ // The second parameter in DidToggleFullscreenModeForTab should be false,
+ // indicating that the fullscreen change will *not* cause a resize.
+ EXPECT_CALL(fullscreenObserver,
+ DidToggleFullscreenModeForTab(false, false));
+ ASSERT_TRUE(InvokeEvent(TAB_FULLSCREEN_FALSE));
+ testing::Mock::VerifyAndClearExpectations(&fullscreenObserver);
+
+ ASSERT_TRUE(InvokeEvent(TOGGLE_FULLSCREEN));
+ ASSERT_TRUE(InvokeEvent(WINDOW_CHANGE));
+ ASSERT_FALSE(browser()->window()->IsFullscreen());
+
+ // Go into tab fullscreen only. Exiting tab fullscreen should *not* cause
+ // a call to WasResized since the window will change size and we want the
+ // fullscreen change and size change to be in one Resize message.
+ ASSERT_TRUE(InvokeEvent(TAB_FULLSCREEN_TRUE));
+ ASSERT_TRUE(InvokeEvent(WINDOW_CHANGE));
+ ASSERT_TRUE(browser()->window()->IsFullscreen());
+
+ // The second parameter in DidToggleFullscreenModeForTab should now be true,
+ // indicating that the fullscreen change *will* cause a resize.
+ EXPECT_CALL(fullscreenObserver,
+ DidToggleFullscreenModeForTab(false, true));
+ ASSERT_TRUE(InvokeEvent(TAB_FULLSCREEN_FALSE));
+ ASSERT_FALSE(browser()->window()->IsFullscreen());
+ testing::Mock::VerifyAndClearExpectations(&fullscreenObserver);
+}
+
// Tests that the state of a fullscreened, screen-captured tab is preserved if
// the tab is detached from one Browser window and attached to another.
//
« no previous file with comments | « chrome/browser/ui/exclusive_access/fullscreen_controller.cc ('k') | components/guest_view/browser/guest_view_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698