content/public/browser/web_contents.h - Issue 1488653002: Fix scroll restoration when exiting fullscreen mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents.h

Issue 1488653002: Fix scroll restoration when exiting fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from scheib@ Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/public/browser/screen_orientation_provider.cc ('k') | content/public/browser/web_contents_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/web_contents.h

diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h

index 6f68c96273a453be2afb952657410e8c5908a2e5..e2ffacdb36eef6d4147c128fa653b227bbe95800 100644

--- a/content/public/browser/web_contents.h

+++ b/content/public/browser/web_contents.h

@@ -669,7 +669,9 @@ class WebContents : public PageNavigator,

virtual void HasManifest(const HasManifestCallback& callback) = 0;

// Requests the renderer to exit fullscreen.

- virtual void ExitFullscreen() = 0;

+ // |will_cause_resize| can be false in the case where we exit tab fullscreen

Avi (use Gerrit) 2016/01/05 16:17:57 Same comment here. "will be false in the case"?

bokan 2016/01/05 17:15:48 Done.

+ // into browser fullscreen and thus won't cause bounds to change.

+ virtual void ExitFullscreen(bool will_cause_resize) = 0;

// Unblocks requests from renderer for a newly created window. This is

// used in showCreatedWindow() or sometimes later in cases where