content/browser/web_contents/web_contents_impl.h - Issue 1488653002: Fix scroll restoration when exiting fullscreen mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 1488653002: Fix scroll restoration when exiting fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from scheib@ Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_delegate.h ('K') | « content/browser/web_contents/web_contents_android.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index ceb900e9a006081263027f11a5ec327692717164..912262c712fd3350f5183a67415228942c87d7c0 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -375,7 +375,7 @@ class CONTENT_EXPORT WebContentsImpl

bool WasRecentlyAudible() override;

void GetManifest(const GetManifestCallback& callback) override;

void HasManifest(const HasManifestCallback& callback) override;

- void ExitFullscreen() override;

+ void ExitFullscreen(bool will_cause_resize) override;

void ResumeLoadingCreatedWebContents() override;

#if defined(OS_ANDROID)

void OnMediaSessionStateChanged();

@@ -439,7 +439,7 @@ class CONTENT_EXPORT WebContentsImpl

GeolocationServiceContext* GetGeolocationServiceContext() override;

WakeLockServiceContext* GetWakeLockServiceContext() override;

void EnterFullscreenMode(const GURL& origin) override;

- void ExitFullscreenMode() override;

+ void ExitFullscreenMode(bool will_cause_resize) override;

bool ShouldRouteMessageEvent(

RenderFrameHost* target_rfh,

SiteInstance* source_site_instance) const override;